Implement eth/v1/beacon/execution_payload_envelope#10537
Implement eth/v1/beacon/execution_payload_envelope#10537akronim26 wants to merge 16 commits intoConsensys:masterfrom
eth/v1/beacon/execution_payload_envelope#10537Conversation
| SafeFuture<InternalValidationResult> validateAndImportExecutionPayload( | ||
| SignedExecutionPayloadEnvelope signedExecutionPayload, Optional<UInt64> arrivalTimestamp); | ||
| SignedExecutionPayloadEnvelope signedExecutionPayload, | ||
| Optional<UInt64> arrivalTimestamp, |
Check notice
Code scanning / CodeQL
Useless parameter Note
|
@rolfyone, please review whenever you are free |
rolfyone
left a comment
There was a problem hiding this comment.
looks pretty good! Some mostly minor things. Hopefully soon the other PR is merged (beacon-api) with no other changes required...
|
@rolfyone, please take a look |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 78faa33. Configure here.
|
i've updated the PR with current master etc, sorry there's been a bunch on.
There's some cursorbot things I haven't fully digested but potentially it might have some valid feedback here too... |
|
ah ok - so yeh its in an open PR, and I was looking at the committed version thats published on beacon-apis. super confusing. will try to get the existing PR progressed so its clearer, sorry for the confusion... for reference, was looking at https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/ValidatorRequiredApi/submitPayloadAttestationMessages when i reviewed @akronim26 |

PR Description
This PR implements
eth/v1/beacon/execution_payload_envelopeendpoint. It uses overloading ofpublishSignedExecutionPayloadfunction to support the query paramblock_validation.Fixed Issue(s)
Fixes #10416
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Adds a new validator-required REST endpoint and threads
broadcast_validationthrough multiple layers of execution-payload publishing/validation, changing behavior and signatures across validator, statetransition, and remote-client code paths.Overview
Implements
POST /eth/v1/beacon/execution_payload_envelope(Gloas) to broadcast aSignedExecutionPayloadEnvelope, including parsing/validating thebroadcast_validationquery param and mapping results to200/202/400.Threads optional
BroadcastValidationLevelthroughValidatorApiHandler→ExecutionPayloadPublisher→ExecutionPayloadManager/ExecutionPayloadGossipValidator, including a new short-circuit path (e.g.,NOT_REQUIRED) and updated “seen” handling forGOSSIP.Updates the remote validator client to call the new endpoint (method enum + typedef request), expands
PublishSignedExecutionPayloadResultwithnotImported, and refreshes tests/spec JSON fixtures accordingly.Reviewed by Cursor Bugbot for commit 78faa33. Bugbot is set up for automated code reviews on this repo. Configure here.