Merged
Conversation
…uto-discovery can still override them later. Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
zilm13
reviewed
Mar 30, 2026
|
|
||
| ### Bug Fixes No newline at end of file | ||
| ### Bug Fixes | ||
| - Fixed ipv6 discovery No newline at end of file |
Contributor
There was a problem hiding this comment.
Maybe explain it more, smth like "Fixed automatic detection of local node IPv6 address"
| "The configured advertised IPs must be either 1 or 2"); | ||
| if (advertisedIps.size() == 1) { | ||
| nodeRecordBuilder.address( | ||
| advertisedIps.get(0), discoConfig.getAdvertisedUdpPort(), p2pConfig.getAdvertisedPort()); |
Contributor
There was a problem hiding this comment.
will it work if only ipv6 is configured?
Contributor
Author
There was a problem hiding this comment.
tested and it does work when only the ipv6 interface is configured I haven't tried advertising the IPs since the purpose of this is for the client to discover the ips by themselves when we only specify the interface in this case either --p2p-interface="::" or --p2p-interface="0.0.0.0" --p2p-interface="::" would work
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
# Conflicts: # CHANGELOG.md
lucassaldanha
previously approved these changes
Apr 17, 2026
# Conflicts: # CHANGELOG.md
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 186ee81. Configure here.
…namically Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
lucassaldanha
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Populate the initial ENR with the resolved listen addresses, auto-discovery can still override them later. requires Consensys/discovery#202
Fixed Issue(s)
Fixes #10305
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Touches discovery/ENR initialization and local address selection logic, which can impact peer connectivity (especially dual-stack) and is backed by a discovery library upgrade.
Overview
Fixes IPv6 discovery by broadening local IPv6 auto-detection to select any non-loopback, non-link-local address, and by always seeding the initial discv5 ENR with the resolved advertised IP(s)/ports (including dual-stack) so discovery starts with correct addresses.
Upgrades the discovery dependency from
tech.pegasys.discoverytoio.consensys.protocols:discovery(newer version) across modules, updates bootnode acceptance tests to assert only the deterministic ENR public-key portion, and records the IPv6 detection fix inCHANGELOG.md.Reviewed by Cursor Bugbot for commit f76e35f. Bugbot is set up for automated code reviews on this repo. Configure here.