Stop publishing release images to GHCR#71
Open
gontzess wants to merge 1 commit intogontzess/axiomatic-release-workflow-cleanupfrom
Open
Stop publishing release images to GHCR#71gontzess wants to merge 1 commit intogontzess/axiomatic-release-workflow-cleanupfrom
gontzess wants to merge 1 commit intogontzess/axiomatic-release-workflow-cleanupfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Connector release images no longer need to be published to GHCR. Keeping the GHCR path means extra registry auth, extra image metadata, and extra attestation verification for an output that is no longer consumed.
This PR is stacked on #69 and should merge after it.
What this changes
Validation
go test ./...git diff --check.github/workflows/release.yaml.goreleaser-docker-oci-template.yaml.tmplwith sample values and parsed it as YAMLmake protogenmake docsv0.1.122-test.8: Docker enabled, no GHCR login step, ECR Public publish, manifest publication, registry API recording, and release verification passed