Preserve release attestations in registry ingest#68
Merged
Conversation
kans
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release manifests already include per-asset provenance and SBOM attestations plus an image attestation summary, but record-release dropped those fields before calling the registry API. Exported stable manifests could therefore lose verification metadata even when the per-version manifest and Sigstore bundles existed.
What this changes
This keeps per-asset attestation descriptors in the registry request and maps the manifest-level image attestation summary onto each image record, matching the connector-registry importer and exporter model. Asset attestation summaries remain derived from per-asset entries; image attestations remain OCI-referrer based, so their bundle URL may be empty.
Tests cover asset attestation preservation, incomplete asset entries, image attestation fan-out, and the JSON request shape.