Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
6fa7b93 to
2256394
Compare
robert-chiniquy
approved these changes
Mar 3, 2026
8ce7559 to
4b39af0
Compare
Three fixes to the regression verify step: 1. Move flags before the positional arg so Go's flag.Parse sees them. Was: `verify mysql --binary ...` (flags silently ignored) Now: `verify --binary ... mysql` 2. Checkout connector to a path matching its name (e.g., baton-mysql) instead of generic `connector`. The --source flag derives the connector config name from the directory basename. 3. Re-add --source with the correct path so code coverage analysis works in CI. Also validates the connector input is alphanumeric (with hyphens and underscores) to prevent path traversal or injection via the checkout path and shell arguments.
4b39af0 to
80e7cf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flag.Parsesees them--sourcepath: checkout connector topath: ${{ inputs.connector }}(e.g.,baton-mysql) instead of genericconnector, so the tool derives the correct config name from the directory basename^baton-[a-zA-Z0-9_-]+$Context
The verify step was invoked as
verify mysql --binary ./bin/baton-mysql .... Go'sflag.Parsestops at the first non-flag argument, so all flags aftermysqlwere silently ignored. The tool fell back tobinary_pathfrom the config file (~/repo/baton-mysql/dist/...), a local dev path that doesn't exist in CI.The
--sourcepath was../connector(the checkout directory name), causingfilepath.Baseto derive config nameconnectorinstead ofmysql.Verified
Tested on baton-mysql PR #24 — regression job passes with full coverage:
Test plan