fix: pass token to regression job, add docs#57
Merged
Conversation
Add secrets: inherit to the regression job in verify.yaml so RELENG_GITHUB_TOKEN flows through to baton-regression for private repo checkout. Add README section and docs/verify-workflow.md covering the verify workflow's three jobs (lint, test, regression), inputs, and usage.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
kans
approved these changes
Mar 3, 2026
Keep both the new Custom MSI Installers section from main and the Verify Workflow section from this branch.
README now has just the usage example and parameter table. Detailed job descriptions, regression testing, secrets, and usage variants are in docs/verify-workflow.md.
Pass only the specific secret needed for private repo access rather than all org secrets. Limits exposure in the reusable workflow chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RELENG_GITHUB_TOKENexplicitly to the regression job in verify.yaml for private baton-regression repo checkoutdocs/verify-workflow.mdContext
The regression job calls baton-regression's reusable workflow, which needs
RELENG_GITHUB_TOKENto check out the private baton-regression repo. Uses explicit secret passing rather thansecrets: inheritto limit exposure to only the token needed.Companion PR: ConductorOne/baton-regression#3 (fixes the checkout target in regression.yml)
Test plan