Skip to content

fix: pass token to regression job, add docs#57

Merged
gontzess merged 4 commits intomainfrom
gontzess/fix-regression-secrets-and-docs
Mar 3, 2026
Merged

fix: pass token to regression job, add docs#57
gontzess merged 4 commits intomainfrom
gontzess/fix-regression-secrets-and-docs

Conversation

@gontzess
Copy link
Copy Markdown
Contributor

@gontzess gontzess commented Mar 3, 2026

Summary

  • Pass RELENG_GITHUB_TOKEN explicitly to the regression job in verify.yaml for private baton-regression repo checkout
  • Add verify workflow documentation to README and docs/verify-workflow.md

Context

The regression job calls baton-regression's reusable workflow, which needs RELENG_GITHUB_TOKEN to check out the private baton-regression repo. Uses explicit secret passing rather than secrets: inherit to limit exposure to only the token needed.

Companion PR: ConductorOne/baton-regression#3 (fixes the checkout target in regression.yml)

Test plan

  • After merge, update v4 tag to include this commit
  • Re-run verify on a connector with regression enabled (e.g., baton-mysql) to confirm the full chain works

Add secrets: inherit to the regression job in verify.yaml so
RELENG_GITHUB_TOKEN flows through to baton-regression for private
repo checkout.

Add README section and docs/verify-workflow.md covering the verify
workflow's three jobs (lint, test, regression), inputs, and usage.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 3, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • .github/workflows/verify.yaml is excluded by none and included by none
  • README.md is excluded by none and included by none
  • docs/verify-workflow.md is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gontzess/fix-regression-secrets-and-docs

Comment @coderabbitai help to get the list of available commands and usage tips.

gontzess added 3 commits March 3, 2026 12:20
Keep both the new Custom MSI Installers section from main and the
Verify Workflow section from this branch.
README now has just the usage example and parameter table.
Detailed job descriptions, regression testing, secrets, and
usage variants are in docs/verify-workflow.md.
Pass only the specific secret needed for private repo access rather
than all org secrets. Limits exposure in the reusable workflow chain.
@gontzess gontzess changed the title fix: pass secrets to regression job, add verify workflow docs fix: pass RELENG_GITHUB_TOKEN to regression job, add verify workflow docs Mar 3, 2026
@gontzess gontzess changed the title fix: pass RELENG_GITHUB_TOKEN to regression job, add verify workflow docs fix: pass token to regression job, add docs Mar 3, 2026
@gontzess gontzess merged commit a4d1ea4 into main Mar 3, 2026
2 checks passed
@gontzess gontzess deleted the gontzess/fix-regression-secrets-and-docs branch March 3, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants