Build recommendation quality feedback loop using skip history and mute preferences#148
Build recommendation quality feedback loop using skip history and mute preferences#148Shubb07 wants to merge 14 commits into
Conversation
|
@Shubb07 is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Siddhartha-singh01
left a comment
There was a problem hiding this comment.
The penalty design here is solid subtractive soft penalties with documented
constants in constants.ts is exactly the right approach. But I ran CI's steps
locally and the PR isn't mergeable yet:
-
Typecheck fails. You added
repoLanguage: string | nullas a required field on
ScoredIssue, but didn't updaterecommend.test.tsitsissue()factory
builds ScoredIssue objects withoutrepoLanguage. Exact error:
recommend.test.ts(4,61): error TS2322: ... not assignable to type 'ScoredIssue'.
Fix: addrepoLanguage(e.g.repoLanguage: null) to the factory's base object. -
Format check fails on
src/app/actions/profile.ts. Runnpm run formatand
commit. -
Migration numbering:
0010_recommendation_feedback.sqlis the third0010_
migration main already has0010_add_failed_webhook_eventsand
0010_add_profile_fields. Please rename it to the next free number. -
Most important for a "recommendation quality" PR: the new penalty logic (repo
skip, language skip, muted repo/language) has no test coverage at all —
recommend.test.ts wasn't touched. Please add tests for the penalties in
rankScore so the ranking behavior is actually verified.
Run npm run typecheck, npm run format, and npm test locally all three need
to be green before this can merge. The design is good; it just needs the build
fixed and the new logic tested.
|
Please see this #67 (comment) |
Summary
Improves recommendation quality by incorporating contributor feedback signals into the recommendation ranking pipeline.
The recommendation engine now:
Type of Change
Related Issue
Closes #91
What was changed?
skip_reasonpersistence for skipped recommendationsScreenshots
N/A (backend/recommendation pipeline enhancement)
Checklist
npm run dev)