feat: add conditional variable display by Soare-Robert-Daniel · Pull Request #590 · Codeinwp/woocommerce-product-addon

Soare-Robert-Daniel · 2026-04-27T13:27:35Z

Summary

Will affect visual aspect of the product

YES

Screenshots

Test instructions

Warning

This feature is marked as PRO. You will need to activate the PRO plugin.

Create a variable product & PPOM field group.
Test if you can attach the PPOM field group to a single variation of the variable product.
Test the purchase workflow to see if it works like the others (tags, categories, etc).

Check before Pull Request is ready:

I have written a test and included it in this PR
I have run all tests and they pass
The code passes when running the PHP CodeSniffer
Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
Security and Sanitization requirements have been followed
I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes https://github.com/Codeinwp/ppom-pro/issues/512

pirate-bot · 2026-04-27T13:29:46Z

Tip

You can preview the changes in the Playground

Plugin build for 7c74e27 is ready 🛎️!

Download PPOM - build 🔗

Copilot

Pull request overview

Adds “attach PPOM group to specific variations” support so PPOM groups can be conditionally displayed on variable products, with corresponding backend filtering to prevent inactive-group fields/prices from being validated or priced.

Changes:

Store per-product variation rule maps and expose helper APIs to resolve active PPOM groups per selected variation.
Update add-to-cart validation, cart item payload handling, and pricing to ignore PPOM fields belonging to inactive variation-restricted groups.
Add admin UI support (Select2 variation search + save flow) and frontend show/hide behavior, plus unit + E2E coverage.

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
woocommerce-product-addon.php	Defines meta key constant used to store variation display rules.
src/Support/Helpers.php	Adds variation rule-map storage + filtering helpers for posted payloads.
templates/frontend/ppom-fields.php	Emits group wrapper metadata (`data-ppom-allowed-variations`) for frontend toggling.
js/ppom-variation-rules.js	Implements variation-driven group show/hide + input disabling on product pages.
src/WooCommerce/Product/ProductHandler.php	Extends validation to be variation-aware and skip inactive-group fields.
src/WooCommerce/Cart/CartHandler.php	Filters PPOM cart payload/fees by active variation to prevent stale/inactive data.
src/Pricing/Engine.php	Filters posted field list by active variation before pricing rows are built.
inc/woocommerce/product.php	Updates WC validation filter wrapper to accept variation context args.
inc/woocommerce/cart.php	Updates WC cart-item-data filter wrapper to accept variation/quantity args.
classes/plugin.class.php	Updates WooCommerce filter registrations to the new arg counts.
classes/frontend-scripts.class.php	Registers/enqueues the new variation rules frontend script.
classes/fields.class.php	Adds localized strings/actions needed for variation Select2 search.
js/admin/ppom-meta-table.js	Adds Select2 wiring for “attach to variations” in modal + inline UI.
classes/admin.class.php	Adds variation search endpoint + attach UI component + save plumbing for variation rules.
src/Admin/Manager.php	Persists inline attach selections (including variations) during group create/update.
inc/functions.php	Adds public wrapper functions for variation rule helpers.
tests/unit/test-variation-attach.php	Unit coverage for rule map storage and payload/validation filtering behavior.
tests/e2e/specs/variation-attach.spec.js	E2E coverage ensuring group renders only for allowed variation.
tests/e2e/fixtures/ppom.js	Adds fixture helper to attach a PPOM group to variations via bootstrap action.
tests/e2e/fixtures/index.js	Re-exports the new variations attach fixture helper.
bin/wp-env/mu-plugins/ppom-e2e-bootstrap.php	Adds an E2E bootstrap AJAX action to attach groups to variations.
phpcs.baseline.xml	Updates baseline for new/shifted PHPCS findings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+	function setGroupActive( $group, active ) {
+		if ( active ) {
+			$group.show().attr( 'aria-hidden', 'false' );
+			setInputsDisabled( $group, false );
+			setConditionHiddenClass( $group, false );
+			$( document ).trigger( 'ppom_field_shown' );
+		} else {
+			$group.hide().attr( 'aria-hidden', 'true' );
+			setInputsDisabled( $group, true );
+			setConditionHiddenClass( $group, true );
+			$( document ).trigger( 'ppom_field_hidden' );
+		}


+			array(
+				'results'    => $results,
+				'pagination' => array(
+					'more' => '' === $search_term && $page < (int) $query->max_num_pages,


+		$product_ids = get_posts(
+			array(
+				'post_type'              => 'product',
+				'post_status'            => 'publish',
+				'posts_per_page'         => -1,
+				'fields'                 => 'ids',
+				'no_found_rows'          => true,
+				'update_post_meta_cache' => false,
+				'update_post_term_cache' => false,
+				'meta_key'               => PPOM_VARIATION_META_KEY,
+			)
+		);
+
+		$variation_ids = array();
+		foreach ( $product_ids as $product_id ) {
+			$variation_ids = array_merge(
+				$variation_ids,
+				\PPOM\Support\Helpers::get_variation_ids_for_group( $product_id, $ppom_id )
+			);
+		}
+
+		return array_values( array_unique( array_filter( array_map( 'absint', $variation_ids ) ) ) );


poonam279 · 2026-05-01T22:17:34Z

@Soare-Robert-Daniel, I checked the PR and the variation conditions are working correctly. I have two questions:

Selecting a variation also attaches this group to its parent product, but removing all variations does not auto-detach the product. This might surprise merchants who expect the fields to disappear from the product once all variation restrictions are cleared. Is this expected behavior?
When I type a keyword to search for a product, category, or variation, the keyword remains visible even after selection. Can we clear it after an item is selected?

I also noticed that if I deactivate the Pro version after adding a variation condition and then remove the parent product from the product list, some field types lose their registered title and data name. This seems like a bug—could you take a look?

The error in debug log is [01-May-2026 23:01:07 UTC] PHP Warning: Undefined array key "title" in /s3-puzzledturkey/wordpress/wp-content/plugins/woocommerce-product-addon/src/Hooks/Callbacks.php on line 655

poonam279 · 2026-05-04T15:52:47Z

@Soare-Robert-Daniel, this issue e stil exists.

I also noticed that if I deactivate the Pro version after adding a variation condition and then remove the parent product from the product list, some field types lose their registered title and data name. This seems like a bug—could you take a look?

I noticed it with the color and font picker fields.

Debug log has these entries

[04-May-2026 15:32:22 UTC] PHP Warning:  Undefined array key "visibility" in /s3-puzzledturkey/wordpress/wp-content/plugins/woocommerce-product-addon/classes/fields.class.php on line 961
[04-May-2026 15:32:22 UTC] PHP Warning:  Undefined array key "bound" in /s3-puzzledturkey/wordpress/wp-content/plugins/woocommerce-product-addon/classes/fields.class.php on line 963
[04-May-2026 15:47:30 UTC] PHP Warning:  Undefined array key "visibility" in /s3-puzzledturkey/wordpress/wp-content/plugins/woocommerce-product-addon/classes/fields.class.php on line 961
[04-May-2026 15:47:30 UTC] PHP Warning:  Undefined array key "bound" in /s3-puzzledturkey/wordpress/wp-content/plugins/woocommerce-product-addon/classes/fields.class.php on line 963
[04-May-2026 15:49:55 UTC] PHP Warning:  Undefined array key "visibility" in /s3-puzzledturkey/wordpress/wp-content/plugins/woocommerce-product-addon/classes/fields.class.php on line 961
[04-May-2026 15:49:55 UTC] PHP Warning:  Undefined array key "bound" in /s3-puzzledturkey/wordpress/wp-content/plugins/woocommerce-product-addon/classes/fields.class.php on line 963

Soare Robert-Daniel added 5 commits April 17, 2026 16:57

feat: allow product search on Attach to Product select

ca6c864

feat: inline attach to products with search for categories & tags

1b2d5e7

chore: format

aa8ab8f

chore: format

d3cdc9b

chore: update baseline

d9c2449

Soare-Robert-Daniel self-assigned this Apr 27, 2026

Soare-Robert-Daniel requested a review from Copilot April 27, 2026 13:27

pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Apr 27, 2026

Copilot started reviewing on behalf of Soare-Robert-Daniel April 27, 2026 13:28 View session

Copilot AI reviewed Apr 27, 2026

View reviewed changes

Soare-Robert-Daniel changed the title ~~feat: add conditional veriation display~~ feat: add conditional variable display Apr 28, 2026

Soare-Robert-Daniel requested a review from abaicus April 28, 2026 10:34

Soare-Robert-Daniel changed the base branch from feat/search-products to development May 4, 2026 13:43

Soare-Robert-Daniel force-pushed the feat/variation-product-attach branch from 18727a1 to 4e0df9b Compare May 4, 2026 13:48

Soare-Robert-Daniel and others added 8 commits May 4, 2026 16:53

Merge branch 'development' into feat/search-products

5f173e8

feat: add conditional veriation display

9d1e2c8

chore: update e2e tests

3f368f3

chore: phpstan

c8cf46f

chore: code review

af71151

chore: phpstan

4f36026

chore: reported issues

d65df1e

chore: phpstan

1f132f3

Soare-Robert-Daniel force-pushed the feat/variation-product-attach branch from 4e0df9b to 1f132f3 Compare May 4, 2026 14:02

Soare-Robert-Daniel added 2 commits May 5, 2026 14:19

refactor: make variation indep of product

e1ea8eb

chore: update e2e tests

7c74e27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add conditional variable display#590

feat: add conditional variable display#590
Soare-Robert-Daniel wants to merge 15 commits intodevelopmentfrom
feat/variation-product-attach

Soare-Robert-Daniel commented Apr 27, 2026

Uh oh!

pirate-bot commented Apr 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

poonam279 commented May 1, 2026 •

edited

Loading

Uh oh!

poonam279 commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Soare-Robert-Daniel commented Apr 27, 2026

Summary

Will affect visual aspect of the product

Screenshots

Test instructions

Check before Pull Request is ready:

Uh oh!

pirate-bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

poonam279 commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

poonam279 commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pirate-bot commented Apr 27, 2026 •

edited

Loading

poonam279 commented May 1, 2026 •

edited

Loading