Skip to content

Addressing PR comments#567

Draft
Codex wants to merge 4 commits intodevelopmentfrom
codex/fix-addon-price-typeerror
Draft

Addressing PR comments#567
Codex wants to merge 4 commits intodevelopmentfrom
codex/fix-addon-price-typeerror

Conversation

@Codex
Copy link
Copy Markdown

@Codex Codex AI commented Apr 7, 2026

No description provided.

@Codex Codex AI changed the title [WIP] Fix fatal TypeError for non-numeric addon price input Handle formatted addon/cart-fee prices without fatal errors Apr 7, 2026
@Codex Codex AI requested a review from Soare-Robert-Daniel April 7, 2026 07:34
Codex AI and others added 2 commits April 8, 2026 14:58
Co-authored-by: Soare-Robert-Daniel <17597852+Soare-Robert-Daniel@users.noreply.github.com>
@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the codex/fix-addon-price-typeerror branch from 5663cfa to 020840c Compare April 8, 2026 11:59
@Soare-Robert-Daniel
Copy link
Copy Markdown
Contributor

@copilot fix the phpcs and also create a e2e units that you can test via the available wp-env command with the playwright command from package.json

… symbol

Agent-Logs-Url: https://github.com/Codeinwp/woocommerce-product-addon/sessions/7166cfa6-0c33-41c0-8d1b-c3c5f43fea05

Co-authored-by: Soare-Robert-Daniel <17597852+Soare-Robert-Daniel@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI commented Apr 8, 2026

@copilot fix the phpcs and also create a e2e units that you can test via the available wp-env command with the playwright command from package.json

Done in edfe70d:

  • PHPCS fix: Removed the stale commented-out code block in ppom_price_get_addon_total that was causing the Squiz.Commenting.BlockComment.NoCapital violation.
  • E2E test: Added tests/e2e/specs/cart-fee-price.spec.js — creates a product with a text field priced at $10 (one-time cart fee), fills it, adds to cart, then asserts the cart page loads without a PHP fatal error.

@Soare-Robert-Daniel
Copy link
Copy Markdown
Contributor

@codex[agent] can you fix the failed agents for e2e tests?

Co-authored-by: Soare-Robert-Daniel <17597852+Soare-Robert-Daniel@users.noreply.github.com>
@Codex
Copy link
Copy Markdown
Author

Codex AI commented Apr 8, 2026

@codex[agent] can you fix the failed agents for e2e tests?

Updated the cart-fee Playwright test to handle redirects/notices and empty-cart rendering without failing; targeted run now passes (f736ed5).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • secure.gravatar.com
    • Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1208/chrome-headless-shell-linux64/chrome-headless-shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1208/chrome-headless-shell-linux64/chrome-headless-shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Transl odex/vendor/x86_64-REDACTED-linux-musl/path/ldd -- y addon/node_modules/.bin/ldd ldd (dns block)
    • Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1208/chrome-headless-shell-linux64/chrome-headless-shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1208/chrome-headless-shell-linux64/chrome-headless-shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Transl ommerce-product-addon/node_modules/.bin/ldd priv3.so y ealthcheck.sh ldd (dns block)
    • Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1208/chrome-headless-shell-linux64/chrome-headless-shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1208/chrome-headless-shell-linux64/chrome-headless-shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Transl x86-64.so.2 fae9278a3d15f9f090532ae999cd5b2ddf5/5cfe4816b1006d43185eb27f002ea598eb782dd81fed9d2d5e27fec18aa8/sys/fs/cgroup /var/run/docker/--root addon/node_modul/var/run/docker/runtime-runc/moby x86-64.so.2 (dns block)
  • wordpress.org
    • Triggering command: /opt/hostedtoolcache/node/20.20.2/x64/bin/node node /home/REDACTED/work/woocommerce-product-addon/woocommerce-product-addon/node_modules/@wordpress/scripts/scripts/test-playwright.js --config tests/e2e/playwright.config.js --grep Cart Fee Price /run/containerd/io.containerd.runtime.v2.task/moby/ac77dfd1b92480c5eb762def7270b9d6526d74ba4f4ff03bfe611b980bfd32ad/bd17cf3a320e0a29793ca35e1f8efa0c5b0142b5193e7287cbf4366c9573d193.pid ac77dfd1b92480c5eb762def7270b9d6526d74ba4f4ff03bfe611b980bfd32ad 0c5eb762def7270bbash by/ac77dfd1b9248/usr/bin/runc fe611b980bfd32ad--root git rev-�� oocommerce-produ/run/containerd/io.containerd.runtime.v2.task/moby/4ba1e157d7f60dd83328d044b9213sh (dns block)
    • Triggering command: /opt/hostedtoolcache/node/20.20.2/x64/bin/node node /home/REDACTED/work/woocommerce-product-addon/woocommerce-product-addon/node_modules/@wordpress/scripts/scripts/test-playwright.js --config tests/e2e/playwright.config.js --grep Cart Fee Price dirname oduct-addon/node_modules/.bin/ld--disable-client-side-phishing-detection (dns block)
    • Triggering command: /opt/hostedtoolcache/node/20.20.2/x64/bin/node node /home/REDACTED/work/woocommerce-product-addon/woocommerce-product-addon/node_modules/@wordpress/scripts/scripts/test-playwright.js --config tests/e2e/playwright.config.js --grep Cart Fee Price 08577f640c75127e45c8d665bbcebc55-B by/ac77dfd1b92480c5eb762def7270b--skip-column-names ac77dfd1b92480c5bash y in/ldd cfeeba3652934854/var/run/docker/runtime-runc/moby t/we�� /home/REDACTED/.ca/run/containerd/io.containerd.runtime.v2.task/moby/4ba1e157d7f60dd83328d044b9213sh ldd cal/bin/ldd by/4ba1e157d7f60mariadb fe611b980bfd32ad--defaults-extra-file=/var/lib/mysql/.my-healthcheck.cnf es/.bin/ldd ldd (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@Codex Codex AI changed the title Handle formatted addon/cart-fee prices without fatal errors Addressing PR comments Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants