Skip to content

Add note about CR timing to guide#1775

Merged
LonMcGregor merged 2 commits intomainfrom
lm-cr-time
Mar 11, 2026
Merged

Add note about CR timing to guide#1775
LonMcGregor merged 2 commits intomainfrom
lm-cr-time

Conversation

@LonMcGregor
Copy link
Contributor

From our code review meeting, add a reminder to trainees to try to respond promptly to feedback on PRs

TODO: Also add a note to the first couple of PR backlog tickets

@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 4ab00aa
🔍 Latest deploy log https://app.netlify.com/projects/cyf-curriculum/deploys/69b1a678911c3c0008efdf04
😎 Deploy Preview https://deploy-preview-1775--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 4ab00aa
🔍 Latest deploy log https://app.netlify.com/projects/cyf-launch/deploys/69b1a67837eb7b0008204a38
😎 Deploy Preview https://deploy-preview-1775--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 4ab00aa
🔍 Latest deploy log https://app.netlify.com/projects/cyf-sdc/deploys/69b1a678cc9a66000863b10b
😎 Deploy Preview https://deploy-preview-1775--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 4ab00aa
🔍 Latest deploy log https://app.netlify.com/projects/cyf-tracks/deploys/69b1a678fa0c6100084ce4f1
😎 Deploy Preview https://deploy-preview-1775--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 4ab00aa
🔍 Latest deploy log https://app.netlify.com/projects/cyf-programming/deploys/69b1a67802a5260008b8bbb1
😎 Deploy Preview https://deploy-preview-1775--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 4ab00aa
🔍 Latest deploy log https://app.netlify.com/projects/cyf-piscine/deploys/69b1a678411b3500082b6b2e
😎 Deploy Preview https://deploy-preview-1775--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit 4ab00aa
🔍 Latest deploy log https://app.netlify.com/projects/cyf-common/deploys/69b1a678f350850007058d5c
😎 Deploy Preview https://deploy-preview-1775--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 4ab00aa
🔍 Latest deploy log https://app.netlify.com/projects/cyf-itd/deploys/69b1a678227f800008541b75
😎 Deploy Preview https://deploy-preview-1775--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion :)

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 👀 In review in Curriculum Planning Mar 11, 2026
Co-authored-by: Daniel Wagner-Hall <daniel@codeyourfuture.io>
@LonMcGregor LonMcGregor enabled auto-merge (squash) March 11, 2026 17:29
@LonMcGregor LonMcGregor merged commit 432ea3a into main Mar 11, 2026
35 checks passed
@LonMcGregor LonMcGregor deleted the lm-cr-time branch March 11, 2026 17:33
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Curriculum Planning Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants