Skip to content

Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 2 | Feature/wireframe#1327

Open
SandzSoft wants to merge 7 commits into
CodeYourFuture:mainfrom
SandzSoft:feature/wireframe
Open

Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 2 | Feature/wireframe#1327
SandzSoft wants to merge 7 commits into
CodeYourFuture:mainfrom
SandzSoft:feature/wireframe

Conversation

@SandzSoft
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Built a semantic HTML page using header, main, article, and footer elements
  • Added three articles covering README files, wireframes, and Git branches
  • Included images, headings, summaries, and external links for each article
  • Styled the page using CSS Grid and basic layout techniques
  • Ensured accessibility best practices (alt attributes and semantic structure)
  • Fixed footer to stay at the bottom of the page

@netlify
Copy link
Copy Markdown

netlify Bot commented May 21, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 780e855
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a16bd2d5761f000083bac82
😎 Deploy Preview https://deploy-preview-1327--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@SandzSoft SandzSoft added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module labels May 21, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 27, 2026
Copy link
Copy Markdown

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, this meets all the criteria.

There is one place you could improve a bit further - Have a look at your footer. It is correctly fixed to the viewport, but as you scroll, do you see how it overlaps? Can that be fixed to ensure it remains readable?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 27, 2026
@SandzSoft
Copy link
Copy Markdown
Author

SandzSoft commented May 27, 2026

Good work, this meets all the criteria.

There is one place you could improve a bit further - Have a look at your footer. It is correctly fixed to the viewport, but as you scroll, do you see how it overlaps? Can that be fixed to ensure it remains readable?

Thank you for the feedback. I understand the issue now — because the footer is fixed to the viewport, the page content can scroll underneath it and become partially hidden. I can fix this by adding bottom padding or margin to the main content so there is enough space for the fixed footer and everything remains readable while scrolling.

@SandzSoft SandzSoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@LonMcGregor
Copy link
Copy Markdown

Good suggestion. But consider also the readability as you scroll. For example, when this happens:
image

Could you try making some changes to the CSS to resolve this?

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@SandzSoft
Copy link
Copy Markdown
Author

Good suggestion. But consider also the readability as you scroll. For example, when this happens: image

Could you try making some changes to the CSS to resolve this?

Thank you for the feedback. I understand the issue now — the fixed footer was overlapping the content while scrolling. I have changed the footer to a static position so it no longer covers the page content and remains readable.

@SandzSoft SandzSoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@LonMcGregor
Copy link
Copy Markdown

So, the readme requires the footer be fixed to the viewport, you had this working correctly already.

But when it overlaps, the test of the footer isn't readable.

There is a change you could make that would ensure readability while keeping the footer fixed and visible always. (hint: could you do anything about the background of the footer?)

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@SandzSoft
Copy link
Copy Markdown
Author

So, the readme requires the footer be fixed to the viewport, you had this working correctly already.

But when it overlaps, the test of the footer isn't readable.

There is a change you could make that would ensure readability while keeping the footer fixed and visible always. (hint: could you do anything about the background of the footer?)

Thank you for the feedback. I understand now — the footer needs to remain fixed to the viewport as required. I have added a background colour to the footer so that it stays readable even when content scrolls behind it, preventing any overlap issues with the text.

@SandzSoft SandzSoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@LonMcGregor
Copy link
Copy Markdown

Great work, this task is complete now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants