Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 2 | Feature/wireframe#1327
Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 2 | Feature/wireframe#1327SandzSoft wants to merge 7 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, this meets all the criteria.
There is one place you could improve a bit further - Have a look at your footer. It is correctly fixed to the viewport, but as you scroll, do you see how it overlaps? Can that be fixed to ensure it remains readable?
Thank you for the feedback. I understand the issue now — because the footer is fixed to the viewport, the page content can scroll underneath it and become partially hidden. I can fix this by adding bottom padding or margin to the main content so there is enough space for the fixed footer and everything remains readable while scrolling. |
|
So, the readme requires the footer be fixed to the viewport, you had this working correctly already. But when it overlaps, the test of the footer isn't readable. There is a change you could make that would ensure readability while keeping the footer fixed and visible always. (hint: could you do anything about the background of the footer?) |
Thank you for the feedback. I understand now — the footer needs to remain fixed to the viewport as required. I have added a background colour to the footer so that it stays readable even when content scrolls behind it, preventing any overlap issues with the text. |
|
Great work, this task is complete now |



Self checklist
Changelist