Skip to content

London | 26-ITP-May | Hugh Mills | Sprint 1 | Form-Control#1309

Open
HM-127BTY wants to merge 7 commits into
CodeYourFuture:mainfrom
HM-127BTY:Hugh-Mills---Sprint-1
Open

London | 26-ITP-May | Hugh Mills | Sprint 1 | Form-Control#1309
HM-127BTY wants to merge 7 commits into
CodeYourFuture:mainfrom
HM-127BTY:Hugh-Mills---Sprint-1

Conversation

@HM-127BTY
Copy link
Copy Markdown

@HM-127BTY HM-127BTY commented May 18, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I added a requirements for Name and Email, as well as requirement to select color and size for tshirt.
Added a select and reset button.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 8284ee6
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a0d9a75c1269100083dcc82
😎 Deploy Preview https://deploy-preview-1309--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (🔴 down 4 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@HM-127BTY HM-127BTY added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 18, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 18, 2026
@HM-127BTY HM-127BTY added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 18, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 18, 2026
@HM-127BTY HM-127BTY added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 21, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 21, 2026
@HM-127BTY HM-127BTY removed the 📅 Sprint 1 Assigned during Sprint 1 of this module label May 21, 2026
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@HM-127BTY
Copy link
Copy Markdown
Author

Made the changes to the PR description.

@HM-127BTY HM-127BTY added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 21, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 21, 2026
@Poonam-raj
Copy link
Copy Markdown
Contributor

Hi @HM-127BTY i think the GitHub bot requires you to remove the sentence "Briefly explain your PR." from the "Changelist" section of your PR template

@HM-127BTY
Copy link
Copy Markdown
Author

Hi @HM-127BTY i think the GitHub bot requires you to remove the sentence "Briefly explain your PR." from the "Changelist" section of your PR template

Ahh thanks, was wondering what was up with it. Thanks for the help there.

@Poonam-raj
Copy link
Copy Markdown
Contributor

Make sure you add that "Needs review" label back in

@HM-127BTY HM-127BTY added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 26, 2026
@JaypeeLan JaypeeLan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants