Birmingham | MAY 2026 | Ogbemi Mene | Sprint 1 | Form control#1294
Open
meneogbemi42-bit wants to merge 7 commits into
Open
Birmingham | MAY 2026 | Ogbemi Mene | Sprint 1 | Form control#1294meneogbemi42-bit wants to merge 7 commits into
meneogbemi42-bit wants to merge 7 commits into
Conversation
added 2 commits
May 16, 2026 14:01
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
meneogbemi42-bit
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 20, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
How can you ensure an accessibility score of 100 in lighthouse?
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>T-shirt sales</title> | ||
| <link rel="stylesheet" href="Untitled-1.css"> |
There was a problem hiding this comment.
What else could you use as file name for the stylesheet to adhere more to standard naming?
| <link rel="stylesheet" href="Untitled-1.css"> | ||
| </head> | ||
|
|
||
| <body> |
There was a problem hiding this comment.
I see 3 errors when checking the file in the w3 validator. How can you fix them?
|
|
||
| <div> | ||
| <label for="name">NAME</label> | ||
| <input type="text" name="name" id="name" placeholder="name" value="name" required> |
There was a problem hiding this comment.
How can you ensure that the name has at least 2 characters?
|
|
||
| <label for="size">size of T-shirt</label> | ||
|
|
||
| <select name="size" id="size" required> |
Luro91
added
Reviewed
meneogbemi42-bit
added
Needs Review
Luro91
reviewed
May 25, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
How can you achieve a lighthouse score of 100?
| <label for="size">size of T-shirt</label> | ||
|
|
||
| <select name="size" id="size" required> | ||
| <option value="XS">XS</option> |
There was a problem hiding this comment.
There is an error in the w3 validator:
Error: The first child option element of a select element with a required attribute, and without a multiple attribute, and without a size attribute whose value is greater than 1, must have either an empty value attribute, or must have no text content. Consider either adding a placeholder option label, or adding a size attribute with a value equal to the number of option elements.
Luro91
added
Reviewed
meneogbemi42-bit
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
on this pull request i created my own form from the beginning with html and css files