-
-
Notifications
You must be signed in to change notification settings - Fork 493
London | 25-ITP-May | Giorgi Natriashvili | Sprint 2 | Wireframe #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Giontr
wants to merge
9
commits into
CodeYourFuture:main
Choose a base branch
from
Giontr:feature/wireframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
177c9e7
Check the push to Git
Giontr da1339f
Upload Pictures for articles and Descriptions
Giontr 5291536
add links to read more
Giontr e407242
footer relative/center
Giontr a7aef08
fixed validator errors and styled fonts of intro and content
Giontr e689d86
center header
Giontr e288a82
Readme changed
Giontr 2289b82
footer fixed on bottom
Giontr ef20f27
Added background color to footer, that it shows above the context whi…
Giontr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,80 @@ | ||
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <title>Software development UNI</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> | ||
| <h1>Code Hub</h1> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| Learn to code with hands-on projects and expert guidance. Join our | ||
| community of developers | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| <img src="Readme.png" alt="README file illustration" /> | ||
| <h2>What is a README file?</h2> | ||
| <p class="intro"> | ||
| A README is the front door of any software project — the first | ||
| document a visitor reads when they encounter your code. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| <p class="content"> | ||
| Typically named README.md and written in Markdown, it lives at the | ||
| root of a repository and renders automatically on platforms like | ||
| GitHub. Its core purpose is to answer three questions immediately: | ||
| what does this project do, how do I get it running, and how do I use | ||
| it?<br />A well-crafted README... | ||
| </p> | ||
| <a href="https://en.wikipedia.org/wiki/README" target="_blank" | ||
| >Read more</a | ||
| > | ||
| </article> | ||
| <article> | ||
| <img src="Wireframe1.png" alt="Wireframe illustration" /> | ||
| <h2>What is a WIREFRAME?</h2> | ||
| <p class="intro"> | ||
| A wireframe is a skeletal blueprint of a digital interface — a | ||
| low-fidelity sketch that maps out layout and structure before any | ||
| visual design begins. | ||
| </p> | ||
| <p class="content"> | ||
| Think of it as the floor plan of a building: it shows where the rooms | ||
| are, how they connect, and how large each space is — but says nothing | ||
| about paint colours or furniture. In UI/UX design, wireframes... | ||
| </p> | ||
| <a | ||
| href="https://en.wikipedia.org/wiki/Website_wireframe" | ||
| target="_blank" | ||
| >Read more</a | ||
| > | ||
| </article> | ||
| <article> | ||
| <img src="git-branch.png" alt="Git branch illustration" /> | ||
| <h2>What is a BRANCH in Git?</h2> | ||
| <p class="intro"> | ||
| A branch in Git is an independent line of development — a lightweight | ||
| pointer that lets you work on changes in isolation without affecting | ||
| the main codebase. | ||
| </p> | ||
| <p class="content"> | ||
| Imagine a river that splits into a side channel. Work can proceed | ||
| along the side channel independently; later, the two streams can be | ||
| merged back together. In Git, this is exactly what a branch does: it | ||
| diverges from a point in the commit history so | ||
| </p> | ||
| <a | ||
| href="https://en.wikipedia.org/wiki/Branching_(version_control)" | ||
| target="_blank" | ||
| >Read more</a | ||
| > | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| <p>© Giorgi Natriashvili. All rights reserved.</p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 23-25 can be better formatted as:
To understand why, you can ask AI these questions:
VSCode's "Format Document" feature can help us format our code for better readability and consistency, including breaking a long line of text into shorter lines of text. You can refer to this guide for more info about enabling "Format on Save" in VS Code or using VS Code's "Format Document" feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I changed paragraph format and fixed footer to the bottom too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the VS Code's formatter?
If you are using a formatter, all paragraphs would also be updated automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had extension prettier as formatter however I didn't knew I have to format it manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you also enable "Format on save" and "Format on paste", then the code will be formatted automatically (unless there are syntax errors in the code).