London | 25-SDC-Nov | Jesus del Moral | Sprint 1 | Implement unfollow feature#188
Open
delmorallopez wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London | 25-SDC-Nov | Jesus del Moral | Sprint 1 | Implement unfollow feature#188delmorallopez wants to merge 1 commit intoCodeYourFuture:mainfrom
delmorallopez wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
delmorallopez
added
the
Needs Review
illicitonion
reviewed
May 5, 2026
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Generally looks good, two small questions!
Comment on lines
+25
to
+26
| if follow_user is None: | ||
| return |
Member
There was a problem hiding this comment.
Doing nothing if the user doesn't exist kind of works, but also kind of doesn't.
On the plus side, the request didn't make sense, so we didn't do anything wrong.
On the down side, maybe the user actually wanted to follow someone new, and by ignoring their request, we haven't told them they probably made a mistake in their request.
How do you think is the best way to handle this?
| ) | ||
|
|
||
|
|
||
| def unfollow(*, follower: User, follow_username: str): |
Member
There was a problem hiding this comment.
It seems strange that you would have two different copies of this same code in different functions - why do you?
illicitonion
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the ability for users to unfollow other users, improving control over their timeline and social graph