London | 25-SDC-Nov | Jesus del Moral | Sprint 1 | Feature-Rebloom#187
Open
delmorallopez wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London | 25-SDC-Nov | Jesus del Moral | Sprint 1 | Feature-Rebloom#187delmorallopez wants to merge 1 commit intoCodeYourFuture:mainfrom
delmorallopez wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
delmorallopez
added
the
Needs Review
illicitonion
reviewed
May 5, 2026
Comment on lines
+39
to
+40
| # Only extract hashtags if it's a normal bloom | ||
| if content: |
Member
There was a problem hiding this comment.
This is an interesting check. If you removed it, it would work exactly the same (because if content is empty, we won't find any hashtags in it, by definition).
But deciding not to index reblooms for hashtags feels like a reasonable choice. I'd maybe gate this check on if not original_bloom_id though, to be more clear about what we're gating on.
illicitonion
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the re-bloom functionality, allowing users to re-share existing blooms