London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 1 | Fix hashtag slowing down my browser#174
Open
aydaeslami wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 1 | Fix hashtag slowing down my browser#174aydaeslami wants to merge 1 commit intoCodeYourFuture:mainfrom
aydaeslami wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
aydaeslami
added
Needs Review
illicitonion
reviewed
May 5, 2026
| apiService.getBloomsByHashtag(hashtag); | ||
|
|
||
| if (state.currentHashtag !== hashtag) { // fetches only when the hashtag changes | ||
| state.updateState({ currentHashtag: hashtag }); |
Member
There was a problem hiding this comment.
getBloomsByHashtag already updates state itself, so I wouldn't also update it here.
There's a risk that otherwise, if someone calls render after this updateState runs but before the blooms are fetched, then we'll end up showing the new hashtag as a title but the old blooms in the feed, which would be incorrect/confusing.
illicitonion
reviewed
May 5, 2026
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This looks good, and fixes the problem - just one suggestion to consider :)
illicitonion
added
Reviewed
illicitonion
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Prevents blank flash when clicking hashtags by parsing content off-DOM before rendering.