refactor: make scanner an importable package with real GitHub client#5
Merged
packet-mover merged 1 commit intomainfrom Apr 5, 2026
Merged
Conversation
- Change all files from package main to package scanner - Add real GitHubClient implementation (REST API with pagination) - Add ListFiles to GitHubClient interface (stub for upcoming rules) - Add Run() as high-level entry point: constructs client, scans, returns - Add Config struct (Org, Token, ReportRepo) for callers - Make Rule an interface with concrete types per rule (HasRepoDescription) - Rule.Check returns bool; RuleResult assembled in scanner - Move main.go to cmd/scanner/main.go as thin CLI wrapper - Rename client_mock.go to client_mock_test.go (test-only) - Update AGENTS.md repo layout and Phase 2/3 workflow Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
packet-mover
added a commit
that referenced
this pull request
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package maintopackage scanner— the module is now importable by the GitHub App repo viascanner.Run(ctx, cfg)GitHubClientimplementation (REST API with pagination)Rulean interface with concrete types per rule (HasRepoDescription);Checkreturnsboolmain.gotocmd/scanner/main.goas a thin CLI wrapperclient_mock_test.go)Test plan
go test ./...passesgo vet ./...cleango build ./cmd/scannerproduces a working binary