refactor: replace hand-rolled HTTP client with google/go-github#25
Merged
packet-mover merged 1 commit intomainfrom Apr 7, 2026
Merged
refactor: replace hand-rolled HTTP client with google/go-github#25packet-mover merged 1 commit intomainfrom
packet-mover merged 1 commit intomainfrom
Conversation
Switches realGitHubClient from manual HTTP/JSON handling to google/go-github v72, reducing client.go from 263 to 160 lines. Also bumps Go to 1.26.1 and handles 403 on rulesets/branch protection endpoints (private repos without GitHub Pro). Interface, mock, tests, and all other files unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client.gowithgoogle/go-githubv72, reducing the file from 263 to 160 linesGetRulesetsandGetBranchProtection- private repos without GitHub Pro return 403 on these endpoints, which should fall through gracefully (same as 404) rather than failing the scanThe
GitHubClientinterface, mock, all tests, scanner logic, rules, and report generation are unchanged.Test plan
go test ./...passesgo build ./...succeeds