Merged
Conversation
- Upgrade Koin to version 4.2.0 and Android Gradle Plugin to 8.9.1. - Update `compileSdkVersion` and `targetSdkVersion` to 36. - Implement KSP-based Koin Annotations setup in `build-logic`. - Migrate `feature-search` DI from manual DSL to Koin Annotations (`@Module`, `@Factory`, `@KoinViewModel`). - Update `StreamsCarousel` to use `app.cash.paging` imports. - Add `statusBarsPadding` to `ListStreamsScreen` and update `MainActivity` window configuration. - Fix Koin compiler library reference in version catalog.
- Replace `@ExternalDefinition` with `@Provided` for `HttpClient` in `SearchStreamServiceImpl`. - Add `@Provided` annotation to `HttpClient` dependency in `MostPopularMoviesServiceImpl`.
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports
|
gmoro1
reviewed
Mar 20, 2026
| @Factory(binds = [MostPopularMoviesService::class]) | ||
| class MostPopularMoviesServiceImpl( | ||
| private val client: HttpClient | ||
| @Provided private val client: HttpClient |
gmoro1
reviewed
Mar 20, 2026
| } | ||
|
|
||
| ksp { | ||
| arg("KOIN_CONFIG_CHECK", "true") |
There was a problem hiding this comment.
If true, anything weird will fail in compile time
rviannaoliveira
approved these changes
Mar 26, 2026
rviannaoliveira
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Checklist
Issues Relacionadas