perf(col_str): reduce max memory usage#437
Open
zdyj3170101136 wants to merge 1 commit intoClickHouse:mainfrom
Open
perf(col_str): reduce max memory usage#437zdyj3170101136 wants to merge 1 commit intoClickHouse:mainfrom
zdyj3170101136 wants to merge 1 commit intoClickHouse:mainfrom
Conversation
Contributor
Author
|
@ernado cc |
ernado
approved these changes
Oct 22, 2024
Contributor
Author
|
@ernado could you merge it ? |
jdef
reviewed
Nov 14, 2024
ernado
requested changes
Feb 18, 2025
Collaborator
ernado
left a comment
There was a problem hiding this comment.
Please address the question in review comments.
|
I am unsure if a resolved conversation will be visible enough for people reviewing, hence this comment. From my understanding, if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
here is memory inuse bytes pprof.
the ColStr WriteColumn copy the buf.
reduce max memory usage bytes by use writev.