SECNG-4492 | Move from buildpacks/xenial to debian/stable#107
Merged
Conversation
This is a really weird build process. It relies on copying from some build process, which is uhhh. Unknown. But! Since nothing is built in the image shipped to ECR, we should be able to get away with having a very slim distribution for launch.
87b30a2 to
9d81cbe
Compare
andruwm
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clever Coding Standards Agreement
JIRA
SECNG-4492
Overview
This is a really weird build process. It relies on copying from some build process, which is uhhh. Unknown.
But! Since nothing is built in the image shipped to ECR, we should be able to get away with having a very slim distribution for launch.
This is being done to address a gap with the repo's bump to a modern version of go, which uses a modern version of
libc. Currently, when run on this version, there's an issue:Testing
This wasn't tested end-to-end, because this relies on our build process, and the underlying image that is pushed to ECR.Pretty sure that this just copies the artifact from CI. CI uses https://circleci.com/developer/images/image/cimg/go, which uses:
xenial(at best) has libc6 v2.23.noble(at best) has libc6 v2.39. However, we use slim debian images, which should still have a modern version of libc, which should be supported.By downloading this built image and running, we can see that the issue is no longer on running
sphinxd:Rollout
(are there any special rollout considerations? specific steps? risks?)
Rollback
(specific steps? risks?)