Skip to content

cml_node | making started/stopped/wiped states only changing state #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tvarohohlavy wants to merge 4 commits into
base: main
Choose a base branch
from
Open

cml_node | making started/stopped/wiped states only changing state #48

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45dd82b
cml_node - use native wait
tvarohohlavy Jan 8, 2025
8eb543f
cml_node - do not alter node on state change
tvarohohlavy Jan 8, 2025
3d5864e
cml_node - stop running node before wiping it
tvarohohlavy Jan 8, 2025
6d7d370
cleanup
tvarohohlavy Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions plugins/modules/cml_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
version_added: '0.1.0'
options:
state:
description: The desired state of the node
description: The desired state of the node. Started, stopped and wiped are only state changes and require existing node.
required: false
type: str
choices: ['absent', 'present', 'started', 'stopped', 'wiped']
Expand Down Expand Up @@ -159,26 +159,20 @@ def run_module():
if node is None:
cml.fail_json("Node must be created before it is started")
if node.state not in ['STARTED', 'BOOTED']:
if node.state == 'DEFINED_ON_CORE' and cml.params['config']:
node.config = cml.params['config']
if cml.params['image_definition']:
node.image_definition = cml.params['image_definition']
if cml.params['wait'] is False:
lab.wait_for_covergence = False
node.start()
node.start(wait=cml.params['wait'])
cml.result['changed'] = True
elif cml.params['state'] == 'stopped':
if node is None:
cml.fail_json("Node must be created before it is stopped")
if node.state not in ['STOPPED', 'DEFINED_ON_CORE']:
if cml.params['wait'] is False:
lab.wait_for_covergence = False
node.stop()
node.stop(wait=cml.params['wait'])
cml.result['changed'] = True
elif cml.params['state'] == 'wiped':
if node is None:
cml.fail_json("Node must be created before it is wiped")
if node.state not in ['DEFINED_ON_CORE']:
if node.state != 'DEFINED_ON_CORE':
if node.state in ['STARTED', 'BOOTED']:
node.stop(wait=cml.params['wait'])
node.wipe(wait=cml.params['wait'])
cml.result['changed'] = True
cml.exit_json(**cml.result)
Expand Down