Skip to content

Dev python3 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paxcut wants to merge 1 commit into
base: dev-python3
Choose a base branch
from
Open

Dev python3 #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ghida_plugin/lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,15 @@ def ghidra_headless(address,
time.sleep(SLEEP_LENGTH)
counter += 1
subprocess.Popen.poll(p)
if os.name != 'posix':
(out, err) = p.communicate()
out = out.decode('utf-8')
err = err.decode('utf-8')
Copy link
Copy Markdown

@Ivanmatthew Ivanmatthew Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err may sometimes be None, you can fix this with

if os.name != 'posix':
    (out, err) = p.communicate()
    if out is not None:
        out = out.decode('utf-8')
    #else:
    #    print("GhIDA:: [DEBUG] out from process is None")
    if err is not None:
        err = err.decode('utf-8')
    #else:
    #    print("GhIDA:: [DEBUG] err from process is None")


# Process terminated
if p.returncode is not None:
# print("GhIDA:: [DEBUG] ", str(p.stdout.read(), 'utf-8'))
#print("GhIDA:: [DEBUG] ", out)
stop = True
print("GhIDA:: [INFO] Ghidra analysis completed!")
continue
Expand Down