Clarify Full Server Cleanse supported formats#23
Merged
ChrisAdamsdevelopment merged 1 commit intoMay 13, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates user-facing messaging and documentation to accurately describe Full Server Cleanse’s supported formats and MP3 rejection details, without changing any processing logic or routes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The exact 422
detailstring is now duplicated acrossserver.js,README.md, anddocs/manual-qa-checklist.md; consider centralizing the user-facing message in code and having the docs describe intent instead of copying the full literal string to reduce future drift. - The new 422
detailtext is fairly long and mixes guidance and implementation detail; consider tightening the message (e.g., a shorter primary sentence plus a link or secondary explanation) to improve readability in the UI/API response.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The exact 422 `detail` string is now duplicated across `server.js`, `README.md`, and `docs/manual-qa-checklist.md`; consider centralizing the user-facing message in code and having the docs describe intent instead of copying the full literal string to reduce future drift.
- The new 422 `detail` text is fairly long and mixes guidance and implementation detail; consider tightening the message (e.g., a shorter primary sentence plus a link or secondary explanation) to improve readability in the UI/API response.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
/api/processMP3 rejectiondetailtext inserver.jswith:Use Quick Cleanse (Browser) for MP3. Full Server Cleanse is best supported for MP4/M4A; WAV/FLAC may be rejected if ExifTool cannot safely rewrite them.README.mdwording in QA/deployment and Batch API sections to reflect the same safer guidance about MP4/M4A being best-supported and WAV/FLAC potentially rejected.docs/manual-qa-checklist.mdexpected 422detailtext to match the new backend message exactly.Testing
Validated under supported Node runtime
20.20.2:npm installpassed.npm run buildpassed.server.js,README.md, anddocs/manual-qa-checklist.md.package.json,package-lock.json,Dockerfile, processor, cleanup, download-token, auth, Stripe, Gemini, or usage logic changes were introduced.rg -n "MP4/M4A/WAV/FLAC|best supported|Quick Cleanse|WAV/FLAC" server.js README.md docs app.tsxto confirm updated wording locations.Summary by Sourcery
Clarify user-facing guidance for Full Server Cleanse supported formats and MP3 rejection messaging without changing backend behavior.
Enhancements:
Documentation: