Skip to content

Clarify Full Server Cleanse supported formats#23

Merged
ChrisAdamsdevelopment merged 1 commit into
mainfrom
codex/clarify-full-server-cleanse-supported-formats
May 13, 2026
Merged

Clarify Full Server Cleanse supported formats#23
ChrisAdamsdevelopment merged 1 commit into
mainfrom
codex/clarify-full-server-cleanse-supported-formats

Conversation

@ChrisAdamsdevelopment
Copy link
Copy Markdown
Owner

@ChrisAdamsdevelopment ChrisAdamsdevelopment commented May 13, 2026

Motivation

  • Update user-facing messaging so Full Server Cleanse does not over-promise WAV/FLAC support and aligns with observed behavior where ExifTool may reject WAV/FLAC rewrites.
  • Ensure documentation and QA guidance match the backend 422 response text for MP3 rejections without changing processing logic or routes.

Description

  • Replaced the /api/process MP3 rejection detail text in server.js with: Use Quick Cleanse (Browser) for MP3. Full Server Cleanse is best supported for MP4/M4A; WAV/FLAC may be rejected if ExifTool cannot safely rewrite them.
  • Updated README.md wording in QA/deployment and Batch API sections to reflect the same safer guidance about MP4/M4A being best-supported and WAV/FLAC potentially rejected.
  • Updated docs/manual-qa-checklist.md expected 422 detail text to match the new backend message exactly.
  • No route behavior, processing logic, package files, Dockerfile, auth, Stripe, Gemini, usage, processor, cleanup, download-token, or metadata-rule logic was changed.

Testing

Validated under supported Node runtime 20.20.2:

  • npm install passed.
  • npm run build passed.
  • Working tree was clean after validation.
  • Confirmed changed-file scope was limited to server.js, README.md, and docs/manual-qa-checklist.md.
  • Confirmed no package.json, package-lock.json, Dockerfile, processor, cleanup, download-token, auth, Stripe, Gemini, or usage logic changes were introduced.
  • Ran rg -n "MP4/M4A/WAV/FLAC|best supported|Quick Cleanse|WAV/FLAC" server.js README.md docs app.tsx to confirm updated wording locations.

Summary by Sourcery

Clarify user-facing guidance for Full Server Cleanse supported formats and MP3 rejection messaging without changing backend behavior.

Enhancements:

  • Revise /api/process MP3 422 response detail to direct users to Quick Cleanse and clarify limited support for non-MP3 formats.

Documentation:

  • Update README to state that Full Server Cleanse is best supported for MP4/M4A and that WAV/FLAC may be rejected if ExifTool cannot safely rewrite them.
  • Align manual QA checklist expected 422 MP3 error detail text with the backend response message.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 13, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates user-facing messaging and documentation to accurately describe Full Server Cleanse’s supported formats and MP3 rejection details, without changing any processing logic or routes.

File-Level Changes

Change Details Files
Adjust MP3 422 error detail message in the Full Server Cleanse endpoint to clarify supported formats and ExifTool behavior.
  • Keep existing MP3 detection and 422 error semantics unchanged.
  • Update the 422 JSON response detail to direct users to Quick Cleanse for MP3 and clarify that Full Server Cleanse is best supported for MP4/M4A while WAV/FLAC may be rejected if ExifTool cannot safely rewrite them.
server.js
Align README API/QA documentation with the new Full Server Cleanse messaging about MP3, MP4/M4A, and WAV/FLAC support.
  • Update QA/deployment section description of Full Server Cleanse behavior to no longer imply broad non-MP3 support and to mention possible WAV/FLAC rejection.
  • Update Batch API section to reiterate that MP3 server cleanse is unsupported, recommend Quick Cleanse for MP3, and clarify MP4/M4A as best supported with conditional WAV/FLAC handling.
README.md
Update manual QA checklist to expect the new MP3 422 detail message verbatim.
  • Replace the generic description of the expected 422 detail field with the exact new backend detail string so QA validation matches production behavior.
docs/manual-qa-checklist.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The exact 422 detail string is now duplicated across server.js, README.md, and docs/manual-qa-checklist.md; consider centralizing the user-facing message in code and having the docs describe intent instead of copying the full literal string to reduce future drift.
  • The new 422 detail text is fairly long and mixes guidance and implementation detail; consider tightening the message (e.g., a shorter primary sentence plus a link or secondary explanation) to improve readability in the UI/API response.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The exact 422 `detail` string is now duplicated across `server.js`, `README.md`, and `docs/manual-qa-checklist.md`; consider centralizing the user-facing message in code and having the docs describe intent instead of copying the full literal string to reduce future drift.
- The new 422 `detail` text is fairly long and mixes guidance and implementation detail; consider tightening the message (e.g., a shorter primary sentence plus a link or secondary explanation) to improve readability in the UI/API response.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ChrisAdamsdevelopment ChrisAdamsdevelopment merged commit a7e24aa into main May 13, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant