Add sending keyword to closures in convenience functions#3
Merged
mattmassicotte merged 1 commit intoChimeHQ:mainfrom Feb 7, 2025
ryanslikesocool:main
Merged
Add sending keyword to closures in convenience functions#3mattmassicotte merged 1 commit intoChimeHQ:mainfrom ryanslikesocool:main
sending keyword to closures in convenience functions#3mattmassicotte merged 1 commit intoChimeHQ:mainfrom
ryanslikesocool:main
Conversation
Contributor
|
This didn't pass CI because I attempted to minimize the amount of conditional compilation needed in I found it incredibly hard to pull this off for the other types, and I'm inclined to just give up on it. It's a ton of work, introduces a lot of noise, and the value of supporting a < 6.0 compiler goes down every day. Long-winded way of saying, let's merge this, and I'm just going to get rid of the 5 compatibility. There are older releases available if someone needs it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality was already possible when directly using convenience functions that provide a continuation (
NSXPCConnection.withContinuation(isolation:function:_:), for example), but now the other convenience functions support it too!I have no easy way of testing with Swift < 6 so none of that is changed.