Support custom decoders in decoding completions#2
Merged
mattmassicotte merged 1 commit intoChimeHQ:mainfrom Feb 4, 2025
ryanslikesocool:main
Merged
Support custom decoders in decoding completions#2mattmassicotte merged 1 commit intoChimeHQ:mainfrom ryanslikesocool:main
mattmassicotte merged 1 commit intoChimeHQ:mainfrom
ryanslikesocool:main
Conversation
Contributor
|
Wow cool! I didn't even know such a thing was possible. Thanks for doing this! (Don't worry about CI, I clearly have to update that) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added arguments to decoding functions to support decoders other than
JSONDecoder.This change requires importing Combine for
TopLevelDecoder, but I figured it's probably fine considering the target platforms for this package.Modified functions still use
JSONDecoder()as a default argument, but will break for consumers in places where the function is referenced by name (withDecodingCompletion(isolation:function:_:)->withDecodingCompletion(isolation:function:using:_:)).