Fix CO2 Compactor descriptions#257
Conversation
Partly this is to give a subscript to the chemical formula and to fix a typo. But mostly it's to fix a misleading bit of mouseover text. I left CO2 non-subscripted in places where someone might try searching for it like the quest book and the recipe encyclopedia.
| core.register_node('sbz_bio:co2_compactor', { | ||
| description = 'CO2 Compactor', | ||
| info_extra = "Stores 30 co2. Habitat regulator doesn't consider it a wall, similar to how airlock works", | ||
| info_extra = "Stores 30 CO₂. Habitat regulator doesn't consider it a wall, but it can be passed through", |
| 'CO2 supply: ', | ||
| 'CO₂ supply: ', | ||
| math.max(co2_supply, co2_supply_temp), | ||
| '\nCO2 demand: ', |
There was a problem hiding this comment.
CO₂ demand
also what other places does CO2 show up
There was a problem hiding this comment.
Oh, good catch. I was searching whole word and didn't consider that it would think printf style escape sequences were part of the word.
This is all I found from file search, but I'll do another without whole-word on. I think it's still good to leave it as CO2 in some places for searchability though. Just not necessary to do so beyond that, imo. If there was a way to tag these things on the back-end that would be even better, but I haven't looked into that.
|
I think that's everything. This is the regex expression I used to trim out as many false positives as possible: We maybe could use CO₂ in the code itself, but I think that would be harder to maintain if we did. So I just left anything that's a variable or a string used for code the way it was. |
I think it does. It's easier to recognize it as a chemical formula and not just some weird acronym. More sophisticated. |
|
ok |
Fix CO2 Compactor descriptions
Fix CO2 Compactor descriptions
3 participants
Partly this is to give a subscript to the chemical formula and to fix a typo ("equivilent"). But mostly it's to fix a misleading bit of mouseover text. I left CO2 non-subscripted in places where someone might try searching for it like the quest book and the recipe encyclopedia.
I'm still not sure why you can pass through CO2 Compactors, but it's obvious from the code that it was intended that you can. If anyone can tell me why they need to be pass-through, I'm very interested because I'm drawing a blank.