Skip to content

Fix XSD 4.2 extraction#105

Merged
kwabenantim merged 2 commits intomainfrom
kwabenantim-patch-1
May 1, 2026
Merged

Fix XSD 4.2 extraction#105
kwabenantim merged 2 commits intomainfrom
kwabenantim-patch-1

Conversation

@kwabenantim
Copy link
Copy Markdown
Member

@kwabenantim kwabenantim commented May 1, 2026 •
edited
Loading

Strip usr/local/ from extracted path

@kwabenantim kwabenantim self-assigned this May 1, 2026
@kwabenantim kwabenantim requested a review from Copilot May 1, 2026 18:31
Copilot AI reviewed May 1, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the XSD installer script to handle the packaging layout change in XSD 4.2+ tarballs by stripping the /usr/local/ prefix during extraction so the install tree matches the expected modulefile layout.

Changes:

  • Adjust extraction behavior for XSD >= 4.2.0 by increasing tar --strip-components during unpacking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/custom/install_xsd.sh
Comment on lines +65 to 67
tar -xJf xsd-${version}-x86_64-linux-glibc2.31.tar.xz -C ${install_dir} --strip-components=3
fi

@kwabenantim
Copy link
Copy Markdown
Member Author

kwabenantim commented May 1, 2026 •
edited
Loading

The package for XSD 4.2 has the executable binary, but no libxsd directory. The executable is all we really need.

@kwabenantim
Copy link
Copy Markdown
Member Author

kwabenantim commented May 1, 2026

@copilot the layout of the 4.2 package won't change, so no need to do a search.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 1, 2026

@copilot the layout of the 4.2 package won't change, so no need to do a search.

Understood — since the tarball layout is stable (xsd-4.2.0-x86_64-linux-glibc2.31/usr/local/), the hard-coded --strip-components=3 is sufficient. No dynamic detection needed.

@kwabenantim kwabenantim merged commit 46631b5 into main May 1, 2026
3 checks passed
@kwabenantim kwabenantim deleted the kwabenantim-patch-1 branch May 1, 2026 18:56
@kwabenantim kwabenantim linked an issue May 5, 2026 that may be closed by this pull request
Building XSD 4.2 fails #102
Open
@kwabenantim kwabenantim mentioned this pull request May 5, 2026
Open
@kwabenantim
Copy link
Copy Markdown
Member Author

kwabenantim commented May 5, 2026

The executable is all we really need

It turns out we need the includes too so these checks have been reinstated (f40d0d4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@kwabenantim kwabenantim

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Building XSD 4.2 fails

3 participants

@kwabenantim