Open the highlighted property of ChartViewBase #5077
Open
R1ick wants to merge 1 commit intoChartsOrg:masterfrom
Open
Open the highlighted property of ChartViewBase #5077R1ick wants to merge 1 commit intoChartsOrg:masterfrom
highlighted property of ChartViewBase #5077R1ick wants to merge 1 commit intoChartsOrg:masterfrom
Conversation
R1ick
changed the title
highlighted property of ChartViewBase
Naveen-C-Ramachandrappa
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals ⚽
This modification is necessary to implement ability to add multiple markers on the chart via .
Implementation Details 🚧
In code we have to be able change
@objc open internal(set) var highlighted: [Highlight]property to properly implement our logic.Now we able to modify
highlightedproperty of ChartView in it's heirs.