Add optional passphrase prompt to SSH key generation#13
Merged
Conversation
Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update workflow to add optional passphrase for SSH encryption
Add optional passphrase prompt to SSH key generation
Mar 10, 2026
ChangeHow
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH keys were generated unconditionally without a passphrase (
-N ""), giving users no choice and creating less secure keys by default.Changes
src/steps/ssh.js— Adds a@clack/promptspasswordprompt after the email step; blank = no passphrase, non-blank requires ≥8 characters; cancelling aborts the flowsrc/utils/shell.js— ExtendsrunStream(cmd, opts)to accept anenvoption forwarded tospawn(), enabling secure env-var injectiontests/ssh.test.js— AddsmockPasswordand four new cases: blank passphrase, passphrase provided, cancel passphrase, prompt message contentSecurity note
The passphrase is never interpolated into the shell command string. It is passed as
SSH_KEYGEN_PASSPHRASEviaspawn'senvoption and referenced as$SSH_KEYGEN_PASSPHRASEin the command, avoiding shell injection:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.