feat: standardized peerdas metrics#7095
Closed
matthewkeil wants to merge 49 commits into
Closed
Conversation
add types stub and epoch config fix types
add some presets add further params and types add data column to types repo and network move to max request data columns to preset add the datacolumns data in blockinput and fix breaking errors in seen gossip blockinput handle data columns in gossip and the seengossip further propagate forkaware blockdata and resolve build/type issues further handle datacolumns sync by range by root and forkaware data handling fix issues chore: update c-kzg to peerDas version feat: add peerDas ckzg functions to interface fix the lookups handle the publishing flow various sync try fixes fixes compute blob side car various misl debuggings and fixes debug and apply fixes and get range and by root sync to work will full custody enable syncing with lower custody requirement use node peerid rather than a dummy string get and use the nodeid from enr and correctly compute subnets and column indexes filterout and connect to peers only matching out custody requiremnt try adding custody requirement add protection for subnet calc get the sync working with devnet 0 correctly set the enr with custody subnet info rebase fixes small refactor
wip: REPLACE THIS COMMIT commit yarn lock rebase fixes fix: update c-zkg install workflow feat: add trustedSetupPrecompute cli flag fix: update trusted-setup for testing fix: update c-zkg install workflow to remove sudo fix: add rsync to apk deps
some network options to control peering behavior allow setting node custody capability via --params use eip754 names for the peerdas config
…tracking nodeid cleanup for network
rebase fixes
fixes for metadata, working locally change the condition to update metadata csc change
…not required for validator
* refactor: getDataColumnSidecars * test: unit test getDataColumnSidecars with mocks from c-kzg library * refactor: use fromHex util * chore: update numbering on mocks * chore: update c-kzg to latest version * chore: fix type export syntax * test: add verification for cells from sidecars * test: add verification to DataColumnSidecars tests * refactor: getDataColumnSidecars for PR comments * feat: narrow type and remove unnecessary conditional * fix: getDataColumnSidecars param type * refactor: rename to computeDataColumnSidecars
* feat: update c-kzg to final DAS version * refactor: use trusted-setup from c-kzg package
* fix: remove unused ckzg build script * fix: remove unused rsync dep from Dockerfile
* feat: update c-kzg to final DAS version * refactor: use trusted-setup from c-kzg package * feat: implement validateDataColumnsSidecars * feat: check block and column commitments match * test: add unit test for validateDataColumnsSidecars * fix: invalid build and update validity condition of validateDataColumnsSidecars * fix: make error messages better * fix: electra vs peerdas type conflict
Member
|
There is a PR related to this ethereum/beacon-metrics#13 |
Member
Author
Sweet. Ill read that more deeply. Looks like the branch I got these from is the one being merged in. Got it from Pari at ethpandops was looking for here: Ill add the couple for gossip and what not |
matthewkeil
added
the
status-do-not-merge
Member
Author
|
The spec is still being hammered out so some of the metric names may change. Will keep this PR open and update accordingly. |
Member
Author
|
Some of the metric were added in the gossipsub package here |
Member
|
this PR seems really stale to me, the diff is out of control, need to rebase or close, it doesn't even serve as demonstration purpose |
Member
yeah. Thoughts? cc @matthewkeil @KatyaRyazantseva |
Member
Author
|
this is based on old spec and i forgot to close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pari requested that these standardized metrics be added to Lodestar. Once matrix reconstruction is implemented, will implement the metrics in that function, added them to the metrics object for now though so they are available in that PR.
https://discord.com/channels/595666850260713488/1252403418941624532/1285889840746856498