Added throttle token and updated config load#893
Open
nsemets wants to merge 1 commit intoCenterForOpenScience:feature/fair-signpostingfrom
Open
Added throttle token and updated config load#893nsemets wants to merge 1 commit intoCenterForOpenScience:feature/fair-signpostingfrom
nsemets wants to merge 1 commit intoCenterForOpenScience:feature/fair-signpostingfrom
Conversation
brianjgeiger
requested changes
Feb 23, 2026
Contributor
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
One thing that may or may not be a problem.
| if (isPlatformServer(platformId)) { | ||
| const environment = inject(ENVIRONMENT); | ||
|
|
||
| if (environment.throttleToken) { |
Contributor
There was a problem hiding this comment.
Does this need to be in a getter to handle the runtime nature of our configuration system?
Collaborator
Author
There was a problem hiding this comment.
No, we don't need it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes