Open
Conversation
- Add antd@6.3.5 to pnpm-workspace.yaml catalog (latest stable v6) - Update @apps/ui-community to use 'antd: catalog:' - Update @ocom/ui-components to use 'antd: catalog:' - @cellix/ui-core remains compatible (peer dep antd>=5.0.0) - All UI packages build successfully with v6 - All tests pass (95 total across UI packages) Migration Details: - Current codebase uses backward-compatible antd APIs - No breaking changes required (Button, Typography, Form, etc. compatible) - @ant-design/icons already at v6.0.2, compatible - @ant-design/pro-layout 7.22.7 has unmet peer dep warning but works fine Tested: - @apps/ui-community build & tests: PASS - @cellix/ui-core build & tests: PASS - @ocom/ui-components build & tests: PASS
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpgrades Ant Design to 6.3.5 via the pnpm catalog and aligns dependent UI packages and components with the new v6 APIs and peer dependency constraints. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
nnoce14
force-pushed
the
feat/antd-6-upgrade
branch
from
893c34b to
1eff9b3
Compare
Member
Author
|
@sourcery-ai review |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In
MenuComponent, you’re callingbuildMenuItems(root.id)twice when constructingitems; compute it once and reuse the result to avoid redundant filtering/work. - Instead of defining a custom
MenuIteminterface and castingitemstoanywith a biome-ignore, consider usingMenuProps['items']/ItemTypefrom antd to align with the v6 Menu typings and remove the need for the explicit cast. - In
RequireAuth,Spacestill expects thedirectionprop in antd v6; changing it toorientationlikely has no effect and should be reverted todirection="vertical".
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `MenuComponent`, you’re calling `buildMenuItems(root.id)` twice when constructing `items`; compute it once and reuse the result to avoid redundant filtering/work.
- Instead of defining a custom `MenuItem` interface and casting `items` to `any` with a biome-ignore, consider using `MenuProps['items']` / `ItemType` from antd to align with the v6 Menu typings and remove the need for the explicit cast.
- In `RequireAuth`, `Space` still expects the `direction` prop in antd v6; changing it to `orientation` likely has no effect and should be reverted to `direction="vertical"`.
## Individual Comments
### Comment 1
<location path="packages/cellix/ui-core/src/components/molecules/require-auth/index.tsx" line_range="44" />
<code_context>
<Space
size={'large'}
- direction="vertical"
+ orientation="vertical"
style={{ textAlign: 'center' }}
>
</code_context>
<issue_to_address>
**issue (bug_risk):** Using `orientation` instead of `direction` on `Space` is likely incorrect for antd v6 and will be ignored.
In antd v6, `Space` still uses the `direction` prop (`'horizontal' | 'vertical'`), not `orientation`. Using `orientation` here will be ignored and may break the layout. Please revert to `direction="vertical"` (or the correct prop for your exact version of `Space`).
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…ion, Table pagination.position → placement) - Updated require-auth component: Space direction='vertical' → orientation='vertical' - Updated community-list component: Table pagination.position → pagination.placement with topEnd value Fixes runtime deprecation warnings from antd 6.3.5 migration. Note: Menu children deprecation warning deferred - conversion to items array requires redesign of menu hierarchy Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nnoce14
force-pushed
the
feat/antd-6-upgrade
branch
from
1eff9b3 to
46143a0
Compare
Member
Author
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The change from
pagination={{ position: ['topRight'] }}topagination={{ placement: ['topEnd'] }}on the Table component doesn’t match Ant Design v6’sTablePaginationConfigAPI (which still usesposition); this may be silently ignored and should be verified against the v6 docs. - Updating
<Space>fromdirection="vertical"toorientation="vertical"appears incorrect for Ant Design v6, sinceSpacestill uses thedirectionprop whileorientationis used by other components likeDivider.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The change from `pagination={{ position: ['topRight'] }}` to `pagination={{ placement: ['topEnd'] }}` on the Table component doesn’t match Ant Design v6’s `TablePaginationConfig` API (which still uses `position`); this may be silently ignored and should be verified against the v6 docs.
- Updating `<Space>` from `direction="vertical"` to `orientation="vertical"` appears incorrect for Ant Design v6, since `Space` still uses the `direction` prop while `orientation` is used by other components like `Divider`.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
gidich
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Upgrade Ant Design dependency to the latest 6.x version (6.3.5) across all UI packages in the repository.
Changes
Migration Details
The codebase uses antd APIs that are backward-compatible with v6:
Testing
All UI packages build and test successfully:
Full repository verification:
Dependency Notes
Closes #196
Summary by Sourcery
Upgrade Ant Design to v6.3.5 and align dependent UI packages with the shared catalog version while updating affected components for v6 API compatibility.
New Features:
Enhancements: