Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1042131a56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (windowlessRenderingEnabled) { | ||
| window_info.SetAsWindowless(0); | ||
| window_info.shared_texture_enabled = (setting && setting->hardwareAcceleration_); | ||
| window_info.external_begin_frame_enabled = true; |
There was a problem hiding this comment.
Setting window_info.external_begin_frame_enabled = true for every windowless browser changes OSR into externally driven frame scheduling, which requires callers to invoke SendExternalBeginFrame() each frame. This commit only exposes a new API but does not wire any internal scheduling path, so existing consumers that relied on normal SetWindowlessFrameRate-driven repainting can stop receiving paint updates after this change unless they add new per-frame calls.
Useful? React with 👍 / 👎.
2 participants
support ExternalBeginFrame in OSR