Merged
Conversation
rscipien
reviewed
Apr 15, 2026
| } catch (Exception ex) { | ||
| return null; | ||
| } | ||
| public Optional<DataFile> find(final Long id) { |
Contributor
There was a problem hiding this comment.
I see that usage of this find in caller is not the way Optional was intended to use with ifPresent, map, orElseThrow etc. So maybe all callers should be reviewed and fixed or this method should return as prev one just DataFile
Contributor
Author
There was a problem hiding this comment.
No .. it means that I didn't wan't to refactor too much at once. - I'll get back to those ugly hacks and fix them later, once this is merged.
rscipien
approved these changes
Apr 15, 2026
added 14 commits
April 15, 2026 11:44
…o repository class
…d moved method, removed unused method
lbownik
force-pushed
the
DataFileServiceBean_refactoring
branch
from
546c0b0 to
ccee65b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.