Closed
Conversation
added 2 commits
March 26, 2026 18:35
… to clutter output with stacktraces
rscipien
reviewed
Apr 10, 2026
|
|
||
| // -------------------- TESTS -------------------- | ||
|
|
||
| @Disabled |
Contributor
There was a problem hiding this comment.
What is problem with this test?
Contributor
Author
There was a problem hiding this comment.
as specified in comment :
"disable suspicoius test tests, as it seems that their only purpose
to clutter output with stacktraces"
Contributor
There was a problem hiding this comment.
I think the problematic test is compareTimes where data is generate using random and year is outside of expected year Unparseable date: "90071769-11-01 19:48:51.665 UTC". The rest did not produce exceptions when i run it. Maybe here is not need to generate 1000 example randomly and only put some concrete ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.