Update README: Separate build instructions and clarify#62
Open
philonor wants to merge 1 commit intoCeON:masterfrom
philonor:master
Open
Update README: Separate build instructions and clarify#62philonor wants to merge 1 commit intoCeON:masterfrom philonor:master
philonor wants to merge 1 commit intoCeON:masterfrom
philonor:master
Conversation
philonor
commented
Nov 7, 2017
philonor
commented
- Move build instructions to end of README and put an own heading to be found more easily
- Clarify that the built JAR file has to be executable
- Move build instructions to end of README and put an own heading to be found more easily - Clarify that the built JAR file has to be executable
dtkaczyk
requested changes
Dec 2, 2017
|
|
||
| - Ensure that Apache Maven is installed (`sudo apt install maven`) | ||
|
|
||
| **Build ** |
Collaborator
There was a problem hiding this comment.
Please remove this additional space, it seems to break the layout: https://github.com/philonor/CERMINE/blob/5c2790f9fd1dc3a087fef698c97bb2663a9a0974/README.md
|
|
||
| Afterwards a new `target` directory is placed within `CERMINE/cermine-impl/` containing a `cermine-impl-<VERSION>-jar-with-dependencies.jar` file. Ensure the file is readable by `java`. | ||
| ``` | ||
| $ chmod u+x target/cermine-impl-<VERSION>-jar-with-dependencies.jar |
Collaborator
There was a problem hiding this comment.
I don't think you need the JAR file to have execute permission. See for example https://stackoverflow.com/questions/2668796/what-are-the-minimum-unix-permissions-to-run-an-executable-jar-file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.