Add php8.1-bcmath extension to fix ScrambleMapping test failure#47
Merged
yaronkoren merged 1 commit intomasterfrom Dec 25, 2025
Merged
Add php8.1-bcmath extension to fix ScrambleMapping test failure#47yaronkoren merged 1 commit intomasterfrom
yaronkoren merged 1 commit intomasterfrom
Conversation
MediaWiki 1.43's ScrambleMapping class requires either bcmath or gmp PHP extension. This fixes the PHPUnit test error: 'ScrambleMapping requires the bcmath or gmp extension'
57103fe to
1d755cb
Compare
Contributor
Author
|
The issue was found while integrating PHPUnit tests in #46 . Before this change, I got: After this change, this test was no longer failing. |
|
🐳 The image based on 57103fe7 commit has been built with |
yaronkoren
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a PHPUnit test failure in the CI pipeline by adding the
php8.1-bcmathextension to the Dockerfile.Problem
The MediaWiki 1.43
ScrambleMappingclass requires either thebcmathorgmpPHP extension. The current Dockerfile was missing both extensions, causing this PHPUnit test error:Solution
Added
php8.1-bcmathto the list of PHP extensions installed in the Docker image. Thebcmathextension provides arbitrary-precision mathematics functions needed by the ScrambleMapping class.Testing
This change will be tested by the existing CI pipeline which runs PHPUnit tests against MediaWiki core.