Merged
Conversation
troyraen
added
bug
troyraen
force-pushed
the
raen/issues/165/spherex-bad-gateway
branch
from
77e3238 to
9d3bbe1
Compare
jkrick
approved these changes
Mar 3, 2026
Contributor
jkrick
left a comment
jkrick
left a comment
There was a problem hiding this comment.
Thanks for putting this in. The only comment I have is to please update the dates at the bottom of each file touched.
bsipocz
approved these changes
Mar 3, 2026
Member
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Minor code cleanup suggestion, otherwise looks good to go.
| print("Time to create cutouts in serial mode: {:2.2f} minutes.".format((time.time() - t1) / 60)) | ||
|
|
||
| # Drop rows that failed to download. | ||
| results_table_serial = results_table_serial[[r["hdus"] is not None for r in results_table_serial]] |
Member
There was a problem hiding this comment.
It maybe useful to keep a tally for the unsuccessful ones, so it's readily available for a retry? (which is not part of the notebook of course)
Co-authored-by: Brigitta Sipőcz <bsipocz@gmail.com>
bsipocz
reviewed
Mar 6, 2026
| ## About this notebook | ||
|
|
||
| **Updated:** 24 October 2025 | ||
| **Updated:** 5 March 2026 |
Member
There was a problem hiding this comment.
Thanks!
Getting this done automatically with a plugin is on my mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #165
For SPHEREx Intro and PSF notebooks, this catches the three errors seen in #165 and retries a few times. The notebooks can't continue without the data, so need to retry rather than just pass.
For SPHEREx Cutouts notebook, this adds a wrapper function that catches the three errors seen in #165 and just passes. The notebook gets a bunch of cutouts, so passing a few should be fine. This notebook also sometimes fails later on after cutouts have been retrieved with a
TypeError: 'NoneType' object is not iterable(seen in builds linked from #165 but weren't copied directly into the issue). I'm pretty sure that's happening for the same reasons, it's just that the errors are getting lost in the background during the parallel processing. In any case, this PR handles them by droppingNones from the table.These changes aren't guaranteed to make the notebooks run if, for example, the service is having an extra hard time. We can increase the number of retries and/or add more error codes to catch in the future if needed.