fix: resolve link checker race condition with Vite assets#96
Merged
Conversation
This was referenced May 6, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link checker was using
--base-url https://www.calconnect.org/which checks all links against the live site. Since the link checker and deployment run concurrently on push to main, the checker would see stale Vite asset hashes that hadn't been deployed yet, producing thousands of false-positive 404s.Switch to
--base _site/which resolves local paths from the built output and still checks external URLs against the internet.Closes #95, Closes #94, Closes #92, Closes #91, Closes #90