Migrate to released jekyll-calconnect-theme ~> 0.3#89
Merged
Conversation
- Replace minima with calconnect-theme gem in Gemfile - Delete base.html, breadcrumbs.html, google-analytics.html, custom-head.html, feedback.html (now provided by theme) - Simplify default.html: remove 350-line inline CSS and inline JS (now in theme SCSS partials and JS files) - Add theme.js and navigation.js imports to application.js - Add nav-toggle click handler to application.js
- Replace local theme path with released gem from rubygems - Delete local overrides for head, header, footer, default layout (now provided by theme's data-driven templates) - Create navigation_header.yml, navigation_footer.yml, social_links.yml for theme's data-driven header/footer - Add logo, logo_dark, header_cta, schema_org to _config.yml - Add all documentation layout + sidebar styles to application.css (theme SCSS partials not loaded through Vite; styles must be local) - Remove unused script.html (legacy jQuery/Bootstrap)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces local theme path dependency with the released
jekyll-calconnect-themegem from rubygems.Changes
gem "jekyll-calconnect-theme", "~> 0.3"(was path-based)logo,logo_dark,header_cta,schema_orgfor theme's data-driven templates_includes/head.html,header.html,footer.html,script.html,_layouts/default.html— all now provided by themenavigation_header.yml,navigation_footer.yml,social_links.ymlfor theme's data-driven header/footer