Ignore deprecated method warnings in test_app PHPStan config#67
Merged
dereuromark merged 1 commit into4.next-cake5from Mar 26, 2026
Merged
Ignore deprecated method warnings in test_app PHPStan config#67dereuromark merged 1 commit into4.next-cake5from
dereuromark merged 1 commit into4.next-cake5from
Conversation
The test_app contains fixture code to exercise the PHPStan rules, not production code. Since the package supports CakePHP ^5.0, we need to allow deprecated methods like newExpr() which was deprecated in 5.3.0. Closes #65
Contributor
|
This looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
method.deprecatedto ignoreErrors inphpstan-test-app.neonThe test_app contains fixture code to exercise the PHPStan rules, not production code. Since the package supports CakePHP ^5.0, we need to allow deprecated methods like
newExpr()which was deprecated in 5.3.0.Closes #65