add caching to GlStateManager#glViewport#3309
Merged
douira merged 2 commits intoCaffeineMC:devfrom Apr 30, 2026
Merged
Conversation
douira
requested changes
Feb 2, 2026
Contributor
douira
left a comment
douira
left a comment
There was a problem hiding this comment.
PR seems ok to me in general, though I don't know anything about the code we're mixing into here. I've just requested two small syntactic changes.
Contributor
|
Any updates? |
Contributor
|
The author did not address to our concerns yet. |
douira
force-pushed
the
gl-viewport-caching
branch
from
f3a6a73 to
8f9a553
Compare
Contributor
|
I've resolved the concerns myself. |
douira
added a commit
that referenced
this pull request
Apr 30, 2026
--------- Co-authored-by: RacoonDog <32882447+racoondog@users.noreply.github.com> Co-authored-by: douira <douira100@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
RenderPassobject created caused a non-memoized call toGL11#glViewport, usually with the same argumentsSumming up all instances of
GlStateManager#glViewportin a spark profile from a simple world with an uncapped framerate:Before: 214.6ms in 60s, or .35% of render thread [spark profile]
After: 3.2ms in 60s [spark profile]