Skip to content

locks down coversations #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-rocca merged 1 commit into from
Mar 17, 2026
Merged

locks down coversations #1695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/controller/registry-org.controller/error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,13 @@ class RegistryOrgControllerError extends idrErr.IDRError {
err.message = 'The requested user can not be created and added to the organization because the organization has hit its limit of 100 users. Contact the Secretariat.'
return err
}

invalidConversationObject () {
const err = {}
err.error = 'BAD_INPUT'
err.message = 'Parameters were invalid: conversation must be an object with a body.'
return err
}
}

module.exports = {
Expand Down
4 changes: 4 additions & 0 deletions src/controller/registry-org.controller/registry-org.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,10 @@ async function updateOrg (req, res, next) {
let updatedOrg
let jointApprovalRequired

if (conversation && (typeof conversation !== 'object' || !conversation.body)) {
return res.status(400).json(error.invalidConversationObject())
}

try {
session.startTransaction()
const isSecretariat = await repo.isSecretariatByShortName(req.ctx.org, { session })
Expand Down
Loading