KFSPTS-36621 Add attachment to preq service and handle PO not found consisitently#1897
Merged
KFSPTS-36621 Add attachment to preq service and handle PO not found consisitently#1897
Conversation
ajd299
reviewed
Mar 19, 2026
Contributor
ajd299
left a comment
ajd299
left a comment
There was a problem hiding this comment.
@jhulslander Please see my feedback items
| return (PaymentRequestDocument) savedPreqDoc; | ||
|
|
||
| } catch (Exception e) { | ||
| LOG.error("createPaymentRequestDocumentFromDto, There was an error create thePaymentRequestDocument", e); |
Contributor
There was a problem hiding this comment.
I think the log message has a typo.
There was an error creating the PaymentRequestDocument
|
|
||
| error.paymentrequest.at.least.one.must.be.entered=At least one {0} must be entered. | ||
| error.paymentrequest.vendor.invalid=Vendor Number {0} is not valid. | ||
| error.paymentrequest.po.invalid=PO Number {0} is not valid. |
Contributor
There was a problem hiding this comment.
Did you mean to remove error.paymentrequest.po.invalid?
Contributor
Author
There was a problem hiding this comment.
good catch, yes, thank you
| AttributeDefinition fileNameDefiition = Mockito.mock(AttributeDefinition.class); | ||
| Mockito.when(fileNameDefiition.getMaxLength()).thenReturn(Integer.valueOf(15)); | ||
| Mockito.when(fileNameDefiition.getValidationPattern()).thenReturn(new AnyCharacterValidationPattern()); | ||
| Mockito.when(service.getAttributeDefinition(Attachment.class.getName(), PaymentRequestDtoFields.ATTACHMENT_FILE_NAME.datadictionaryFieldName)).thenReturn(fileNameDefiition); |
Contributor
There was a problem hiding this comment.
Can this line be separated into multiple lines to make it easier to read?
| Mockito.when(service.getAttributeDefinition(Attachment.class.getName(), PaymentRequestDtoFields.ATTACHMENT_FILE_NAME.datadictionaryFieldName)).thenReturn(fileNameDefiition); | ||
|
|
||
| AttributeDefinition mimeDefiition = Mockito.mock(AttributeDefinition.class); | ||
| Mockito.when(mimeDefiition.getMaxLength()).thenReturn(Integer.valueOf(15)); |
Contributor
There was a problem hiding this comment.
typo mimeDefiition => mimeDefinition
Comment on lines
+244
to
+250
| } else { | ||
| if (!validateAttachmentField(noteDto.getAttachmentMimeType(), PaymentRequestDtoFields.ATTACHMENT_MIME_TYPE.datadictionaryFieldName, results)) { | ||
| String messageBase = configurationService.getPropertyValueAsString(CUPurapKeyConstants.ERROR_PAYMENTREQUEST_FIELD_FORMATTING); | ||
| String formattedMessage = MessageFormat.format(messageBase, PaymentRequestDtoFields.ATTACHMENT_MIME_TYPE); | ||
| results.getErrorMessages().add(formattedMessage); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Could this be refactored to an else if?
Comment on lines
+234
to
+240
| } else { | ||
| if (!validateAttachmentField(noteDto.getAttachmentFileName(), PaymentRequestDtoFields.ATTACHMENT_FILE_NAME.datadictionaryFieldName, results)) { | ||
| String messageBase = configurationService.getPropertyValueAsString(CUPurapKeyConstants.ERROR_PAYMENTREQUEST_FIELD_FORMATTING); | ||
| String formattedMessage = MessageFormat.format(messageBase, PaymentRequestDtoFields.ATTACHMENT_FILE_NAME); | ||
| results.getErrorMessages().add(formattedMessage); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Could this be refactored to else if?
| } else { | ||
| if (!validateAttachmentField(noteDto.getAttachmentFileName(), PaymentRequestDtoFields.ATTACHMENT_FILE_NAME.datadictionaryFieldName, results)) { | ||
| String messageBase = configurationService.getPropertyValueAsString(CUPurapKeyConstants.ERROR_PAYMENTREQUEST_FIELD_FORMATTING); | ||
| String formattedMessage = MessageFormat.format(messageBase, PaymentRequestDtoFields.ATTACHMENT_FILE_NAME); |
Contributor
There was a problem hiding this comment.
Can we use friendly name "File name" instead of ATTACHMENT_FILE_NAME?
Contributor
Author
|
This is ready for review again |
Contributor
Author
|
retest this please |
ajd299
approved these changes
Mar 23, 2026
Contributor
ajd299
left a comment
ajd299
left a comment
There was a problem hiding this comment.
I was able to get this to process in localdev. Merging to develop
jhulslander
added a commit
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.