Completing Listing REST endpoints for GET all and POST by Amormio25 · Pull Request #7 · CSES-Dev/lims-lab-inventory

Amormio25 · 2026-02-14T02:06:33Z

Describe your changes

wrote code for getting all listings in db (GET all)
wrote code for creating a new listing in db (POST)
fixed requested changes and renamed branch for all work relating to listings

Issue ticket number and link

[ Insert Link & Ticket #]

Checklist before requesting a review

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
This change requires a documentation update

arnavjk007

We will also have it where only certain roles can create listings or ping these APIs. So just keep note or maybe comment as a reminder to implement user auth and permissions once that is implemented. For example, only lab admins can create or delete listings so we need to check permissions before we do the process.

…tion for GET requests

arnavjk007

Some minor changes + sorting changes

…now, created indexing for filters in schema file

arnavjk007

Restructuring change for consistency across all services

…w requested changes

…e standards

arnavjk007

Some minor changes

arnavjk007

This looks good, I think the final thing we need is a little bit of unit testing to make sure that the apis work properly. I set up jest on the main branch so make sure to do git merge main in your feat branch to get the updates. Unit testing goes into each folder and creates a new tests file with .test.ts.

…test cases

arnavjk007

Okay I think there is a little confusion abt file structure for tests. In every folder you have a file that needs testing, just create its own tests folder there, here you are creating unit test files in the lib/tests folder which is only meant to test mongoose.

So for your listings.id.route.test.ts, you would create a tests folder in app/api/listings folder and put all route relate testing there.
For services, same thing you would go into services/listings and make a tests with all unit tests testing in your listings.ts file in services.
We don't commit coverage files as that is just for you to look at when you run tests so I would add everything relate to coverage into your .gitignore.
We also need testing on each function I only saw it for the get filtered and a post

…e coverage from git tracking

arnavjk007

update config file

arnavjk007 · 2026-04-07T04:42:17Z


  // Coverage settings
  collectCoverageFrom: [
-    "app/*/.ts",


We don't have to change this file since I already added it in the main branch so just copy the contents of it from the main branch here.

…ates

arnavjk007

Schemas look good

…et and updated POST handler to allow multipart/form-data

arnavjk007

Tests failing, looks good besides that.

…o API

arnavjk007

Looks good to merge.

… doesn't allow)

RBAC

arnavjk007

Conditionally approved, waiting for RBAC svc

arnavjk007

minor reorganizations

arnavjk007 · 2026-04-24T22:46:24Z

+  const { searchParams } = new URL(request.url);
+  const labId = searchParams.get("labId") || undefined;
+  const itemId = searchParams.get("itemId") || undefined;
+  const page = parseInt(searchParams.get("page") || "1");


add validation for page & limit inputs

arnavjk007 · 2026-04-24T22:46:41Z

+ * @returns JSON response with success message and req body echoed
+ */
+async function POST(request: Request) {
+  let { allowed, reason } = await getSession("inventory:create");


we only need listing:create here

arnavjk007 · 2026-04-24T22:47:36Z

+    result.imageUrls = imageUrls;
+  }
+
+  const parsedBody = listingValidationSchema.safeParse(result);


this validation happens after uploading image, lets validate first then upload

arnavjk007 · 2026-04-24T22:49:28Z

+    updateData.imageUrls = imageUrls;
+  }
+
+  const parsedRequest = listingValidationSchema.safeParse(updateData);


upload happens before validation, lets validate first

Amormio25 added 2 commits February 10, 2026 22:27

Completing REST endpoints for GET all and POST

a139891

Fixing requested changes and renaming branch for all listing services

7fe6eca

Amormio25 requested a review from arnavjk007 as a code owner February 14, 2026 02:06

arnavjk007 reviewed Feb 15, 2026

View reviewed changes

Comment thread app/api/listings/route.ts Outdated

arnavjk007 reviewed Feb 15, 2026

View reviewed changes

Comment thread app/api/listings/route.ts Outdated

arnavjk007 reviewed Feb 15, 2026

View reviewed changes

Comment thread app/api/listings/route.ts Outdated

arnavjk007 requested changes Feb 15, 2026

View reviewed changes

Fixed requested changes for GET and POST, mainly filtering and pagina…

55a996b

…tion for GET requests

arnavjk007 requested changes Feb 16, 2026

View reviewed changes

Comment thread app/api/listings/route.ts Outdated

Comment thread app/api/listings/route.ts Outdated

Comment thread app/api/listings/route.ts Outdated

Comment thread app/api/listings/route.ts

Adding logic for maintaining pagination, using validation schema for …

1b1248d

…now, created indexing for filters in schema file

arnavjk007 requested changes Feb 18, 2026

View reviewed changes

Comment thread app/api/listings/route.ts Outdated

Refactoring code to follow product demo files and attempting to follo…

1430fd8

…w requested changes

arnavjk007 requested changes Feb 19, 2026

View reviewed changes

Comment thread app/api/listings/[id]/route.ts Outdated

Comment thread app/api/listings/[id]/route.ts Outdated

Comment thread services/listings/listings.ts Outdated

Refactored listing API methods to ensure consistency with service-wid…

2531c80

…e standards

arnavjk007 requested changes Feb 20, 2026

View reviewed changes

Comment thread app/api/listings/[id]/route.ts Outdated

Comment thread services/listings/listings.ts Outdated

Comment thread services/listings/listings.ts Outdated

Fixing db connections and incorrect variables in listing api routes

6c4024b

arnavjk007 requested changes Feb 21, 2026

View reviewed changes

Amormio25 added 2 commits February 26, 2026 20:02

Merge branch 'main' into listings_svc in order to create listing API …

d0a50ae

…test cases

Push commit to open PR for testing help

91bf583

arnavjk007 requested changes Mar 1, 2026

View reviewed changes

Created several tests for services and api layer, attempting to remov…

fa740b3

…e coverage from git tracking

arnavjk007 requested changes Apr 7, 2026

View reviewed changes

Amormio25 added 2 commits April 7, 2026 08:14

Updating jest config file to match main branch

b460431

Updating listing schema and validation schema to follow front end upd…

fa0bc76

…ates

arnavjk007 reviewed Apr 13, 2026

View reviewed changes

Amormio25 added 2 commits April 14, 2026 09:12

Merge branch 'main' into listings_svc

9e03628

Created GCS utility function for uploading image to free storage buck…

2b75513

…et and updated POST handler to allow multipart/form-data

arnavjk007 requested changes Apr 15, 2026

View reviewed changes

Amormio25 added 2 commits April 15, 2026 20:06

Updating tests and addressing ci/cd test fails

e7b0496

Updating PUT handler to receive formData and adding more test cases t…

e7aee1d

…o API

arnavjk007 previously approved these changes Apr 16, 2026

View reviewed changes

Amormio25 added 2 commits April 18, 2026 17:54

Updated DELETE handler to return 200 to maintain a JSON response (204…

6864f70

… doesn't allow)

Finishing all test cases for API endpoints

ea30d5d

arnavjk007 reviewed Apr 20, 2026

View reviewed changes

Amormio25 and others added 5 commits April 22, 2026 20:42

Merge branch 'main' into listings_svc

fa9959f

Updating authorization checks in listing API

f5de9fb

fixup! Updating authorization checks in listing API

183f9a5

Fixing failed tests by mocking RBAC in test file

5501d2e

Merge branch 'main' into listings_svc

3a9a6cf

arnavjk007 requested changes Apr 24, 2026

View reviewed changes

Fix validation logic for params and form data handling

f0e130a

Amormio25 force-pushed the listings_svc branch from 8630f4b to f0e130a Compare April 25, 2026 02:10

arnavjk007 approved these changes Apr 25, 2026

View reviewed changes

arnavjk007 merged commit e10f485 into main Apr 25, 2026
2 checks passed

Conversation

Amormio25 commented Feb 14, 2026

Describe your changes

Issue ticket number and link

Checklist before requesting a review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arnavjk007 left a comment

Choose a reason for hiding this comment

Uh oh!

arnavjk007 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arnavjk007 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arnavjk007 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arnavjk007 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arnavjk007 left a comment

Choose a reason for hiding this comment

Uh oh!

arnavjk007 left a comment

Choose a reason for hiding this comment

Uh oh!

arnavjk007 Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

arnavjk007 left a comment

Choose a reason for hiding this comment

Uh oh!

arnavjk007 left a comment

Choose a reason for hiding this comment

Uh oh!

arnavjk007 left a comment

Choose a reason for hiding this comment

Uh oh!

arnavjk007 left a comment

Choose a reason for hiding this comment

Uh oh!

arnavjk007 left a comment

Choose a reason for hiding this comment

Uh oh!

arnavjk007 Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

arnavjk007 Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

arnavjk007 Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

arnavjk007 Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

arnavjk007 left a comment •

edited

Loading