Notification Schema#5
Conversation
arnavjk007
left a comment
There was a problem hiding this comment.
Just some minor changes
arnavjk007
left a comment
There was a problem hiding this comment.
Small comment change but everything else looks good
arnavjk007
left a comment
There was a problem hiding this comment.
Small schema type change
arnavjk007
left a comment
There was a problem hiding this comment.
Minor structure change
arnavjk007
left a comment
There was a problem hiding this comment.
Looks good! I think the last step is to write a few simple unit tests to make sure that this works. I have already done the setup for the jest testing env in the main branch so just switch to that and do git pull then go back to the feat and do git merge main to get the updated changes.
arnavjk007
left a comment
There was a problem hiding this comment.
More specific testing + ts-node depencency not installed so unit tests are failing
|
|
||
| import mongoose from "mongoose"; | ||
|
|
||
| describe("startNotificationWatcher", () => { |
There was a problem hiding this comment.
Could we have a simple test that checks if the watcher is triggered over a specific threshold?
Describe your changes
Issue ticket number and link
https://docs.google.com/document/d/1cAICVmUirgPTL-fq3dkHVtx4QkyrG0XCJO7VUxnibdA/edit?usp=sharing
Checklist before requesting a review