Skip to content

bsl 50#49

Open
Thaarak wants to merge 1 commit into
mainfrom
bsl50
Open

bsl 50#49
Thaarak wants to merge 1 commit into
mainfrom
bsl50

Conversation

@Thaarak
Copy link
Copy Markdown
Contributor

@Thaarak Thaarak commented May 4, 2026

No description provided.

@Thaarak Thaarak requested a review from rohanarcot May 4, 2026 17:52
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be committed.. add this to .gitignore and remove from the commit

Comment thread prisma/seed.ts
Comment on lines +13 to +14
{ email: "reviewer@example.com", role: "REVIEWER", name: "Reviewer User" },
{ email: "ambassador@example.com", role: "AMBASSADOR", name: "Ambassador User" },
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep these commented.. gavin will be adding the dev emails soon

Comment thread tests/e2e/apply.spec.ts
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only covers startup form... add the tests for team and organization application forms.. but you can either do it in this PR or the next e2e test PR, up to you.

Comment thread tests/e2e/apply.spec.ts
await expect(page.locator("#contact")).toHaveValue("test@example.com");
});

test("startup application submit button is clickable when form is filled", async ({
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it to, "startup application submit button is enabled when only required fields are filled"

cuz fundingSiteUrl is not a required field

Comment thread CLAUDE.md
- NextAuth configured in `auth.ts` with Google provider
- Session provider wraps app in root `layout.tsx`
- Auth button component at `components/auth/AuthButton.tsx`
- RBAC roles defined but enforcement is TODO
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RBAC already enforced... change it to, "RBAC enforced in API routes via requireRole() in lib/auth-helpers.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants