Conversation
The Organization owner is used in a select statement in the `create-organization` call. In one test it is created, the value is selected and the result is checked. But in this test the value is selected, which fails, and the resulting "empty results" row actually blocks clicking the next button. I'm not sure why this doesn't fail in master, but there must be some tiny styling change or other. However, for consistency, we should make sure we actually create the data that the test expects.
These tests add stuff and try to fill it immediately. We need to wait for the new fields to appear first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly working draft for #2622
Some open issues:
form-idvs.form/id, andfield-idvs.field/id.Checklist for author
Remove items that aren't applicable, check items that are done.
Reviewability
Backwards compatibility
Documentation
Testing
Follow-up