Skip to content

Multiplayer#3430

Draft
Macroz wants to merge 11 commits intomasterfrom
multiplayer4
Draft

Multiplayer#3430
Macroz wants to merge 11 commits intomasterfrom
multiplayer4

Conversation

@Macroz
Copy link
Copy Markdown
Collaborator

@Macroz Macroz commented Feb 24, 2026

Mostly working draft for #2622

Some open issues:

  • File upload is broken, needs investigation.
  • There should be a config whether the applicant only can send the application or can members also.
  • Config should exist whether members are allowed to edit or just view.
  • Test in browser for multiple people editing and seeing the changes.
  • Test API security
  • Test the long poll functionality to make sure it keeps working.
  • Use the same keepalive tactic we have in REMS arleady with the subscription to stop it when the user is not actually doing anything (optimization).
  • Long polling will cause the REMS browser app to reconnect and re-authorize automatically but keepalive would fix this?
  • Same user has many tabs open. Should it have one or many names displayed?
  • Check the UI terminology i.e., Users vs. Applicants vs. ?
  • If reloading the application, it takes one long poll cycle to get the other clients. We could load these immediately.
  • There is some internal naming that could perhaps be improved with form-id vs. form/id, and field-id vs. field/id.
  • Manual mention.
  • Overall, implementation could also include a refactoring of keepalive together with this subscription mechanism so that there exists only one "backchannel" to communicate with REMS:
  • The design uses long-polling because it is fool-proof and simple. A WebSocket API or SSE is possible too, but maybe not worthwhile at the moment. At least the risks with this API style are minimal.
Screenshot_2026-02-24_18-56-16

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue
  • Consider adding screenshots for ease of review

Backwards compatibility

  • API is backwards compatible or completely new
  • Events are backwards compatible or have migrations
  • Config is backwards compatible
  • Feature appears correctly in PDF print

Documentation

  • Update changelog if necessary
  • API is documented and shows up in Swagger UI
  • Components are added to guide page
  • Update docs/ (if applicable)
  • Update manual/ (if applicable)
  • ADR for major architectural decisions or experiments
  • New config options in config-defaults.edn

Testing

  • Complex logic is unit tested
  • Valuable features are integration / browser / acceptance tested automatically

Follow-up

  • New tasks are created for pending or remaining tasks

Macroz added 11 commits January 27, 2025 20:54
The Organization owner is used in a select statement in the
`create-organization` call. In one test it is created, the value is
selected and the result is checked. But in this test the value is
selected, which fails, and the resulting "empty results" row actually
blocks clicking the next button. I'm not sure why this doesn't fail in
master, but there must be some tiny styling change or other. However,
for consistency, we should make sure we actually create the data that
the test expects.
These tests add stuff and try to fill it immediately. We need to
wait for the new fields to appear first.
@meericsc meericsc added the Stat Statistics Finland label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stat Statistics Finland

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants